Closed Bug 1611234 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21389 - Remove assert_throws use in various remaining tests.

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Notable wpt changes
90.35 KB, text/plain
Details

Sync web-platform-tests PR 21389 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21389
Details from upstream follow.

Boris Zbarsky <bzbarsky@mit.edu> wrote:

Remove assert_throws use in various remaining tests.

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Attached file Notable wpt changes — 
# CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 712 tests and 2 subtests

## Status Summary

### Firefox
OK   : 500[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 668[GitHub]
PASS : 42[Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] 4442[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 6803[GitHub]
FAIL : 294[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt] 658[GitHub]
ERROR: 2

### Chrome
OK   : 669
PASS : 6243
CRASH: 1
FAIL : 760

### Safari
OK   : 668
PASS : 5831
FAIL : 1624
ERROR: 2

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=4071b62d62609d8744770310167fb7c5205c3f09)
[GitHub PR Head](https://wpt.fyi/results/?sha=c69749013583b6e5fe51e52a3e0aff1bf4e437a9&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=c69749013583b6e5fe51e52a3e0aff1bf4e437a9&label=pr_base)

## Details

### Firefox-only Failures
/domxpath/002.html
  Select SVG elements with refX attribute: FAIL
  Select SVG element based on mixed case attribute: FAIL
/css/css-ui/parsing/outline-valid-mandatory.html
  e.style['outline'] = "double" should set the property value: FAIL
  e.style['outline'] = "thick" should set the property value: FAIL
  e.style['outline'] = "medium" should set the property value: FAIL
  e.style['outline'] = "solid" should set the property value: FAIL
  e.style['outline'] = "dashed thin" should set the property value: FAIL
  e.style['outline'] = "1px" should set the property value: FAIL
  e.style['outline'] = "dotted" should set the property value: FAIL
  e.style['outline'] = "auto" should set the property value: FAIL
  e.style['outline'] = "inset" should set the property value: FAIL
  e.style['outline'] = "dashed" should set the property value: FAIL
  e.style['outline'] = "ridge" should set the property value: FAIL
  e.style['outline'] = "outset" should set the property value: FAIL
  e.style['outline'] = "none" should set the property value: FAIL
  e.style['outline'] = "calc(2em + 3ex)" should set the property value: FAIL
  e.style['outline'] = "medium rgba(10, 20, 30, 0.4)" should set the property value: FAIL
  e.style['outline'] = "rgba(10, 20, 30, 0.4)" should set the property value: FAIL
  e.style['outline'] = "groove" should set the property value: FAIL
  e.style['outline'] = "0" should set the property value: FAIL
  e.style['outline'] = "thin" should set the property value: FAIL
/css/css-break/parsing/orphans-valid.html
  e.style['orphans'] = "234" should set the property value: FAIL
  e.style['orphans'] = "1" should set the property value: FAIL
/css/css-text/parsing/text-indent-valid.html
  e.style['text-indent'] = "10px hanging" should set the property value: FAIL
/css/css-break/parsing/break-before-valid.html
  e.style['break-before'] = "recto" should set the property value: FAIL
  e.style['break-before'] = "avoid-column" should set the property value: FAIL
  e.style['break-before'] = "avoid-page" should set the property value: FAIL
  e.style['break-before'] = "verso" should set the property value: FAIL
  e.style['break-before'] = "column" should set the property value: FAIL
/css/css-inline/parsing/alignment-baseline-valid.html
  e.style['alignment-baseline'] = "baseline" should set the property value: FAIL
  e.style['alignment-baseline'] = "central" should set the property value: FAIL
  e.style['alignment-baseline'] = "middle" should set the property value: FAIL
  e.style['alignment-baseline'] = "mathematical" should set the property value: FAIL
  e.style['alignment-baseline'] = "ideographic" should set the property value: FAIL
  e.style['alignment-baseline'] = "alphabetic" should set the property value: FAIL
/css/css-values/minmax-length-percent-serialize.html
  e.style['margin-left'] = "max(1em, 10%)" should set the property value: FAIL
  e.style['margin-left'] = "min(10%, 20px)" should set the property value: FAIL
  e.style['margin-left'] = "min(10%, 1em)" should set the property value: FAIL
  e.style['margin-left'] = "min(1em, 10%)" should set the property value: FAIL
  e.style['margin-left'] = "max(20px, 10%)" should set the property value: FAIL
  e.style['margin-left'] = "max(10% + 2em, 5% + 1em)" should set the property value: FAIL
  e.style['margin-left'] = "min(10% + 30px, 5% + 60px)" should set the property value: FAIL
  e.style['margin-left'] = "max(10%, 1em)" should set the property value: FAIL
  e.style['margin-left'] = "max(10%, 20px)" should set the property value: FAIL
  e.style['margin-left'] = "min(20px, 10%)" should set the property value: FAIL
/css/css-break/parsing/break-after-valid.html
  e.style['break-after'] = "avoid-column" should set the property value: FAIL
  e.style['break-after'] = "verso" should set the property value: FAIL
  e.style['break-after'] = "column" should set the property value: FAIL
  e.style['break-after'] = "avoid-page" should set the property value: FAIL
  e.style['break-after'] = "recto" should set the property value: FAIL
/css/css-box/parsing/width-valid.html
  e.style['width'] = "fit-content" should set the property value: FAIL
/webrtc/RTCPeerConnection-constructor.html
  connectionState initial value: FAIL
  new RTCPeerConnection({ iceCandidatePoolSize: toNumberThrows }): FAIL
/css/css-multicol/parsing/column-rule-valid.html
  e.style['column-rule'] = "dotted" should set the property value: FAIL
  e.style['column-rule'] = "red" should set the property value: FAIL
  e.style['column-rule'] = "10px" should set the property value: FAIL
/css/css-masking/parsing/clip-path-valid.html
  e.style['clip-path'] = "circle()" should set the property value: FAIL
  e.style['clip-path'] = "circle(4% at top right)" should set the property value: FAIL
  e.style['clip-path'] = "circle(1px)" should set the property value: FAIL
  e.style['clip-path'] = "circle(farthest-side at center top)" should set the property value: FAIL
  e.style['clip-path'] = "ellipse()" should set the property value: FAIL
  e.style['clip-path'] = "circle(closest-side)" should set the property value: FAIL
  e.style['clip-path'] = "ellipse(1px closest-side)" should set the property value: FAIL
  e.style['clip-path'] = "ellipse(farthest-side 4% at bottom left)" should set the property value: FAIL
/css/css-values/minmax-length-serialize.html
  e.style['letter-spacing'] = "min(20px, 1em, 10vw)" should set the property value: FAIL
  e.style['letter-spacing'] = "max(1px)" should set the property value: FAIL
  e.style['letter-spacing'] = "max(1ex)" should set the property value: FAIL
  e.style['letter-spacing'] = "min(1rem)" should set the property value: FAIL
  e.style['letter-spacing'] = "min(10vw, 1em, 20px)" should set the property value: FAIL
  e.style['letter-spacing'] = "max(1vmax)" should set the property value: FAIL
  e.style['letter-spacing'] = "max(1vw)" should set the property value: FAIL
  e.style['letter-spacing'] = "min(1px)" should set the property value: FAIL
  e.style['letter-spacing'] = "max(10vw, 1em, 20px)" should set the property value: FAIL
  e.style['letter-spacing'] = "min(1vw)" should set the property value: FAIL
  e.style['letter-spacing'] = "min(1vmax)" should set the property value: FAIL
  e.style['letter-spacing'] = "max(1ch)" should set the property value: FAIL
  e.style['letter-spacing'] = "max(1vmin)" should set the property value: FAIL
  e.style['letter-spacing'] = "max(1em)" should set the property value: FAIL
  e.style['letter-spacing'] = "max(1rem)" should set the property value: FAIL
  e.style['letter-spacing'] = "max(1vh)" should set the property value: FAIL
  e.style['letter-spacing'] = "min(1em)" should set the property value: FAIL
  e.style['letter-spacing'] = "min(1ch)" should set the property value: FAIL
  e.style['letter-spacing'] = "max(20px, 1em, 10vw)" should set the property value: FAIL
  e.style['letter-spacing'] = "min(1vmin)" should set the property value: FAIL
  e.style['letter-spacing'] = "min(1ex)" should set the property value: FAIL
  e.style['letter-spacing'] = "min(1vh)" should set the property value: FAIL
/css/css-box/parsing/max-width-valid.html
  e.style['max-width'] = "fit-content" should set the property value: FAIL
/css/css-break/parsing/widows-valid.html
  e.style['widows'] = "1" should set the property value: FAIL
  e.style['widows'] = "234" should set the property value: FAIL
/css/css-shapes/parsing/shape-outside-valid.html
  e.style['shape-outside'] = "circle(1px)" should set the property value: FAIL
  e.style['shape-outside'] = "ellipse(farthest-side 4% at bottom left)" should set the property value: FAIL
  e.style['shape-outside'] = "ellipse()" should set the property value: FAIL
  e.style['shape-outside'] = "circle(4% at top right)" should set the property value: FAIL
  e.style['shape-outside'] = "ellipse(closest-side 1px)" should set the property value: FAIL
  e.style['shape-outside'] = "circle()" should set the property value: FAIL
  e.style['shape-outside'] = "ellipse(3% 2%)" should set the property value: FAIL
  e.style['shape-outside'] = "circle(closest-side)" should set the property value: FAIL
  e.style['shape-outside'] = "circle(farthest-side at center top)" should set the property value: FAIL
  e.style['shape-outside'] = "ellipse(10% closest-side)" should set the property value: FAIL
/css/css-shapes/parsing/shape-outside-valid-position.html
  e.style['shape-outside'] = "circle(at center left)" should set the property value: FAIL
  e.style['shape-outside'] = "circle(at center)" should set the property value: FAIL
  e.style['shape-outside'] = "circle(at bottom right)" should set the property value: FAIL
  e.style['shape-outside'] = "circle(at top center)" should set the property value: FAIL
  e.style['shape-outside'] = "circle(at left)" should set the property value: FAIL
  e.style['shape-outside'] = "circle(at bottom 10% right 20%)" should set the property value: FAIL
  e.style['shape-outside'] = "circle(at top)" should set the property value: FAIL
  e.style['shape-outside'] = "circle(at 10%)" should set the property value: FAIL
/css/css-fonts/parsing/font-language-override-invalid.html
  e.style['font-language-override'] = "\"tr\"" should not set the property value: FAIL
  e.style['font-language-override'] = "\"1 %\"" should not set the property value: FAIL
/css/css-values/minmax-angle-serialize.html
  e.style['transform'] = "rotate(min(1deg))" should set the property value: FAIL
  e.style['transform'] = "rotate(max(1deg))" should set the property value: FAIL
/svg/interact/parsing/pointer-events-valid.svg
  e.style['pointer-events'] = "bounding-box" should set the property value: FAIL
/css/css-values/minmax-time-serialize.html
  e.style['transition-delay'] = "min(1ms)" should set the property value: FAIL
  e.style['transition-delay'] = "max(1ms)" should set the property value: FAIL
/css/css-values/clamp-length-serialize.html
  e.style['letter-spacing'] = "clamp(1px, 2px, clamp(2px, 3px, 4px))" should set the property value: FAIL
  e.style['letter-spacing'] = "clamp(1px, 2px, 3px)" should set the property value: FAIL
/css/css-images/parsing/image-rendering-valid.html
  e.style['image-rendering'] = "pixelated" should set the property value: FAIL
/css/css-box/parsing/max-height-valid.html
  e.style['max-height'] = "fit-content" should set the property value: FAIL
/css/css-lists/parsing/list-style-valid.html
  e.style['list-style'] = "square" should set the property value: FAIL
  e.style['list-style'] = "inside" should set the property value: FAIL
  e.style['list-style'] = "url(\"https://example.com/\")" should set the property value: FAIL
  e.style['list-style'] = "none" should set the property value: FAIL
/css/css-break/parsing/break-inside-valid.html
  e.style['break-inside'] = "avoid-column" should set the property value: FAIL
  e.style['break-inside'] = "avoid-page" should set the property value: FAIL
/css/css-box/parsing/height-valid.html
  e.style['height'] = "fit-content" should set the property value: FAIL
/css/css-lists/parsing/list-style-image-valid.html
  e.style['list-style-image'] = "linear-gradient(to left bottom, red, blue)" should set the property value: FAIL
/css/css-inline/parsing/baseline-shift-valid.html
  e.style['baseline-shift'] = "calc(2em + 3ex)" should set the property value: FAIL
  e.style['baseline-shift'] = "-10px" should set the property value: FAIL
  e.style['baseline-shift'] = "super" should set the property value: FAIL
  e.style['baseline-shift'] = "sub" should set the property value: FAIL
  e.style['baseline-shift'] = "20%" should set the property value: FAIL
/css/css-text/parsing/tab-size-valid.html
  e.style['tab-size'] = "calc(2em + 3ex)" should set the property value: FAIL
  e.style['tab-size'] = "0px" should set the property value: FAIL
  e.style['tab-size'] = "2.5" should set the property value: FAIL
  e.style['tab-size'] = "0" should set the property value: FAIL
  e.style['tab-size'] = "10px" should set the property value: FAIL
/css/css-grid/parsing/grid-template-areas-valid.html
  e.style['grid-template-areas'] = "\"  a  \t  b  \"" should set the property value: FAIL
  e.style['grid-template-areas'] = "\"first ...\"" should set the property value: FAIL
  e.style['grid-template-areas'] = "\"c\td\"" should set the property value: FAIL
/css/css-values/minmax-percentage-serialize.html
  e.style['margin-left'] = "max(1%)" should set the property value: FAIL
  e.style['margin-left'] = "min(1%)" should set the property value: FAIL

(See attachment for full changes)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/659254e6372c
[wpt PR 21389] - Remove assert_throws use in various remaining tests., a=testonly

https://hg.mozilla.org/mozilla-central/rev/659254e6372c

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.