1611236 - Optimize SetAdoptedStyleSheets For Append Case

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Erik Nordin [:nordzilla]]

There are optimizations that can be made in the case of setting the adoptedStyleSheets attribute to a new array that only has appended sheets compared to the previous array.

This change may be affected by https://github.com/WICG/construct-stylesheets/issues/45#issuecomment-577674453, if adoptedStyleSheets is changed to a CSSStyleSheetList and individual methods to insert/append/remove sheets are added.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1611236 - Optimize adoptedStyleSheets append case r=#style!,emilio

• Generalize enumeration over unique sheets to take any array of sheets.
• Add check if the new adoptedStyleSheets only appends sheets.
• Handle append case for new adoptedStyleSheets.
• Add WPT test case for duplicate sheets in the ShadowRoot.
• Add WPT test cases for appending sheets.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77e151138107
Optimize adoptedStyleSheets append case r=emilio

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22051 for changes under testing/web-platform/tests

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/77e151138107

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot