1611431 - Generate mp4parse-rust bindings as part of mach build

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Jon Bauman [:jbauman:]]

Currently the mp4parse-rust C bindings are generated manually when the crate is updated from its GitHub source via the update-rust.sh script. This is inconsistent with other integrated rust code which specify binding generation with RunCbindgen.py in their moz.build files.

As a result, iterating on changes to the rust/C++ interface requires an inconvenient manual process:

1. Remove the build = false line and add back the cbindgen build dependency in media/mp4parse-rust/mp4parse_capi/Cargo.toml
2. Do a cargo build in the mp4parse_capi dir (since mach build fails with error: no matching package named `cbindgen` found)
3. Copy media/mp4parse-rust/mp4parse_capi/include/mp4parse.h → media/mp4parse-rust/mp4parse.h
4. Revert changes to media/mp4parse-rust/mp4parse_capi/Cargo.toml so mach build works again
5. mach build

Changing the binding generation process to be consistent with other code will be more convenient and less error-prone.

Comment 1

[Jon Bauman [:jbauman:]]

Attachment: Bug 1611431 - Generate mp4parse-rust bindings as part of mach build. r=kinetik

Now that cbindgen.toml is a required file, update-rust.sh must be
updated to avoid clobbering it.

Comment 2

[Raul Gurzau (:RaulG)]

Tried to land this on autoland but got the following:

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. applying /tmp/tmp4MayL7 media/mp4parse-rust/mp4parse.h Hunk #1 FAILED at 2. 1 out of 1 hunk FAILED -- saving rejects to file media/mp4parse-rust/mp4parse.h.rej abort: patch command failed: exited with status 256

Comment 3

[Jon Bauman [:jbauman:]]

I rebased, so hopefully that fixes the conflict. I think it was conflicting with this change since that's the only difference I see between my two phabricator revisions.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a431e44d2e6f
Generate mp4parse-rust bindings as part of mach build. r=kinetik

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a431e44d2e6f