v2 personaliztion console error
Categories
(Firefox :: New Tab Page, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: thecount, Assigned: thecount)
References
Details
Attachments
(1 file)
Saw this error this morning while testing it preffed on in nightly:
TypeError: nbTagger.tagTokens is not a function RecipeExecutor.jsm:146:29
I believe it's an issue with loading from cache, which I think the issue starts here:
I don't know if we want to do more validation on the data before using it, or if we can clean up the data we cache. The old AS v2 didn't use this cache, and now I see why. I think it only works as in memory cache, and not persistent cache. So probably best to just not use this item as cache as using it as in memory cache has very little performance gains. I think this time though a comment as to why we cannot cache this would help hitting this again in the future.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
I'm not sure how to reproduce yet or create steps to test. I saw this locally on nightly based on normal usage and normal cache expiring. You need the cache to expire while the browser is closed, so devtools are not great for this because the browser would be open, and thus cache would update after expiring using memory, currently. This is also why I didn't catch it in my initial dev cycle, only while watching things on nightly.
If we think this is something that could use steps to test/verification (it's preffed off on nightly so there isn't any risk in landing it) I can see if it's possible to test it using system time changes while the browser is closed, if this is otherwise unclear.
Pushed by sdowne@getpocket.com: https://hg.mozilla.org/integration/autoland/rev/797dde41ba97 console error from taggers cache r=nanj
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Description
•