Closed Bug 1611493 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21413 - Use assert_precondition on LayoutInstability and EventTiming

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox74 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21413 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21413
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

Use assert_precondition on LayoutInstability and EventTiming

This CL replaces some assert_unreached with assert_precondition and adds
some assert_precondition to tests. The ones that use ScoreWatcher should
already throw an error and not timeout.

Change-Id: Iecda47acce998efac0dc78e5214b60b005c16075
Reviewed-on: https://chromium-review.googlesource.com/2020244
WPT-Export-Revision: 519feee86c299b6e48cdb7317d7473fa96b32df2

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 15 tests and 1 subtests

Status Summary

Firefox

OK : 15
PRECONDITION_FAILED: 15

Chrome

OK : 9
PASS : 8
FAIL : 1
TIMEOUT : 12

Safari

OK : 15
PRECONDITION_FAILED: 15

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/layout-instability/buffer-layout-shift.html
Layout shift before onload is not buffered into the performance timeline.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/event-timing/click-timing.html
Event Timing: compare click timings.: PRECONDITION_FAILED (Chrome: TIMEOUT, Safari: PRECONDITION_FAILED)
/layout-instability/recent-input.html
Layout shift right after user input is observable via PerformanceObserver.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/event-timing/crossiframe.html
Event Timing: entries should only be observable by its own frame.: PRECONDITION_FAILED (Chrome: TIMEOUT, Safari: PRECONDITION_FAILED)
/event-timing/retrievability.html
Event Timing: make sure event-timing entries are not retrievable by performance.getEntries*.: PRECONDITION_FAILED (Chrome: TIMEOUT, Safari: PRECONDITION_FAILED)
/event-timing/supported-types.window.html
supportedEntryTypes contains 'event' and 'first-input'.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/event-timing/programmatic-click-not-observed.html
Event Timing: events from programmatic click are not observed: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/layout-instability/buffered-flag.html
PerformanceObserver with buffered flag sees previous layout-shift entry.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/event-timing/retrieve-firstInput.html
Event Timing: check first-input after onload, observer, click, click.: PRECONDITION_FAILED (Chrome: FAIL, Safari: PRECONDITION_FAILED)
/layout-instability/supported-layout-type.html
supportedEntryTypes contains 'layoutShift'.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/event-timing/only-observe-firstInput.html
Event Timing: check first-input for a PerformanceObserver observing only first-input.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/layout-instability/toJSON.html
Test toJSON() in LayoutShift.: PRECONDITION_FAILED (Chrome: PASS, Safari: PRECONDITION_FAILED)
/event-timing/buffered-flag.html
PerformanceObserver with buffered flag sees previous Event Timing entries: PRECONDITION_FAILED (Chrome: TIMEOUT, Safari: PRECONDITION_FAILED)
/event-timing/timingconditions.html
Event Timing only times certain types of trusted event.: PRECONDITION_FAILED (Chrome: TIMEOUT, Safari: PRECONDITION_FAILED)
/event-timing/toJSON.html
Test toJSON() in PerformanceEventTiming.: PRECONDITION_FAILED (Chrome: TIMEOUT, Safari: PRECONDITION_FAILED)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d14422251a6f
[wpt PR 21413] - Use assert_precondition on LayoutInstability and EventTiming, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b23f78f13690
[wpt PR 21413] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d14422251a6f
https://hg.mozilla.org/mozilla-central/rev/b23f78f13690

Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.