1611494 - Bugzilla custom email headers are getting mashed together

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Email Notifications, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

As of very recently (yesterday or today) the bugzilla plaintext email notifications have the X-Bugzilla headers getting mashed together instead of being on separate lines. Here's a snippet:

X-Bugzilla-Reason: =?UTF-8?Q?None?X-Bugzilla-Type: =?UTF-8?Q?changed?X-Bugzilla-Watch-Reason: =?UTF-8?Q?[e-mail]?X-Bugzilla-Classification: =?UTF-8?Q?Components?X-Bugzilla-ID: =?UTF-8?Q?1601091?X-Bugzilla-Bug-Type: =?UTF-8?Q?defect?X-Bugzilla-Product: =?UTF-8?Q?Core?X-Bugzilla-Component: =?UTF-8?Q?Graphics?X-Bugzilla-Version: =?UTF-8?Q?unspecified?X-Bugzilla-Keywords:           
X-Bugzilla-Severity: =?UTF-8?Q?normal?

These used to be on separate lines.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Note that this about email headers not the email body. And it seems to only happen with plaintext emails; if I use HTML email notifications the headers are properly separated by newlines.

Reopening as this appears to be a different issue from the bug it was duped to.

Comment 3

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Another issue with the headers is that the quoted-printable encoding isn't even correct; it's missing the final = character. e.g.

X-Bugzilla-Reason: =?UTF-8?Q?None?

should actually be

X-Bugzilla-Reason: =?UTF-8?Q?None?=

Presumably your PR will fix this as well. Again, this affects only the plaintext emails, not the HTML ones. Maybe the same code that's truncating off the newlines is truncating off the trailing =.

Comment 5

[David Lawrence [:dkl]]

Merged to master