1611520 - FunctionTypeTraits.h: 'size_t' has not been declared

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Looks like some headers aren't included by default anymore

 0:01.38 In file included from /root/firefox-gcc-last/mfbt/tests/TestFunctionTypeTraits.cpp:7:
 0:01.38 /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/FunctionTypeTraits.h:59:22: error: 'size_t' has not been declared
 0:01.38    59 | template <bool safe, size_t N, typename... As>
 0:01.38       |                      ^~~~~~

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1611520 - gcc-10: Include <cstddef> in FunctionTypeTraits.h r?gerald

Comment 2

[Sylvestre Ledru [:Sylvestre]]

I guess it is Reduced header dependencies, leading to faster compilation for some code from the gcc 10 release notes:
https://gcc.gnu.org/gcc-10/changes.html

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f7f2e18862c
gcc-10: Include <cstddef> in FunctionTypeTraits.h r=gerald

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8f7f2e18862c

Comment 5

[Philip Chimento [:ptomato]]

Comment on attachment 9122978 [details]
Bug 1611520 - gcc-10: Include <cstddef> in FunctionTypeTraits.h r?gerald

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This affects embedders building SpiderMonkey ESR68 with GCC 10 and apparently some version of Clang as well.
• User impact if declined: Standalone SpiderMonkey won't be buildable with GCC 10.
• Fix Landed on Version: 74
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Patch is trivial, and any regressions would be obvious at build time.
• String or UUID changes made by this patch: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9122978 [details]
Bug 1611520 - gcc-10: Include <cstddef> in FunctionTypeTraits.h r?gerald

Simple fix needed for SM to compile with GCC10. Approved for 68.8esr.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/5520d3738273