1611561 - Mousewheel zoom does not always work on freshly-loaded file:// documents

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Brad Werth [:bradwerth]]

This is an intermittent bug. In my testing, if I can launch the browser and get the Expected Result 4 times in a row, I've been counting that as correct behavior.

Steps to Reproduce:

1. Launch a new instance of the browser.
2. In the new tab, load a file:// URL.
3. Attempt to do a mousewheel zoom.

Expected Results:
Zoom level should change.

Actual Results:
Zoom level does not change. It's still possible to change zoom using menu actions.

In my attempt to debug this issue, it seems that the point of failure is in EventStateManager::GetContentViewer, when the BrowserChild determines that its parent is not active.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

If bug 1596317 regressed this, I guess the test has been working accidentally...

Comment 2

[Brad Werth [:bradwerth]]

https://hg.mozilla.org/mozilla-central/rev/0703637be2acb26954dab524c5b957e4b5189b50 is the changeset that causes the regression.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Great, thank you!

It looks like I did make a mistake here https://hg.mozilla.org/mozilla-central/rev/0703637be2acb26954dab524c5b957e4b5189b50#l3.16.

Brad, could you please change the line "return CallState::Stop;" to "return CallState::Continue;" to see whether it fixes the issue?

Comment 4

[Brad Werth [:bradwerth]]

Yes, that seems to fix it.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1611561 - Fix the return value of the callback of CallOnAllRemoteChildren in nsFocusManager::ActivateOrDeactivate. r?smaug

I somehow made this mistake in https://hg.mozilla.org/mozilla-central/rev/0703637be2acb26954dab524c5b957e4b5189b50.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b54c45b2b5d4
Fix the return value of the callback of CallOnAllRemoteChildren in nsFocusManager::ActivateOrDeactivate. r=smaug

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b54c45b2b5d4

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 9123138 [details]
Bug 1611561 - Fix the return value of the callback of CallOnAllRemoteChildren in nsFocusManager::ActivateOrDeactivate. r?smaug

Beta/Release Uplift Approval Request

• User impact if declined: Mouse wheel zooming doesn't work in some conditions
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See bug 1611771 in comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a single line change which restores the condition what we used to use
• String changes made/needed: None

Comment 10

[Alin Ilea, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly Build 74.0a1 (2020-01-24) on Windows 10.
Verified - Fixed in latest Nightly 74.0a1 (Build id: 20200128214036) using Windows 10, Mac OS 10.15 and Ubuntu 18.04.

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9123138 [details]
Bug 1611561 - Fix the return value of the callback of CallOnAllRemoteChildren in nsFocusManager::ActivateOrDeactivate. r?smaug

new regression in 73, verified in nightly; approved for 73.0b12

Comment 12

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0ed7855a2e03

Comment 13

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Beta 73.0b12 (Build id: 20200129151106).