Open Bug 1611643 Opened 3 years ago Updated 13 days ago

Autoplayed next video should also be PIP

Categories

(Toolkit :: Picture-in-Picture, enhancement, P3)

enhancement

Tracking

()

Tracking Status
firefox74 --- affected
firefox77 --- affected
firefox78 --- affected
firefox79 --- affected

People

(Reporter: yoasif, Unassigned)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Seen this asked for on various places, but also experienced a desire for this myself.

  1. Start watching a series on Plex or Netflix
  2. Enter PIP
  3. Navigate to another app (like a game)

Once the next video starts playing (initiated by the website), PIP mode is disabled and the video continues playing in the original window. User has to move back to the Firefox tab and re-enable PIP.

It'd be nice if PIP were to recognize that a video started to play in the same tab that the original PIP video was being played from, and showed the new video in PIP as well.

Blocks: videopip

¡Hola!

Just experienced this in Nightly and it is in fact a bit jarring.

Updating flags accordingly FWIW.

¡Gracias!
Alex

Udemy.com is also affected by this bug when viewing course videos.

By the way, is there a way to bump this? Because it's interfering with my workflow and I can't be the only one.

One idea to address this is to notice when PiP is shut down due to <video> element removal, and to remember the coordinates of the removed <video>... and then have a timer that checks to see if a new <video> element exists at (roughly) the same coordinates, and if so, open that in PiP. That timer would probably need to be on the scale of seconds - say 1 or 2 to start.

This timer should be tied to the lifetime of the document, so if the page navigates away somehow, we should cancel the timer and throw it away.

Blocks: 1685549
Assignee: nobody → katkoor2
Status: NEW → ASSIGNED
Component: Video/Audio Controls → Picture-in-Picture
Attachment #9212818 - Attachment description: Bug 1611643 - Allow PiP to autoplay on Plex. r=mtigley,mhowell → Bug 1611643 - Allow PiP to autoplay on Plex. r=mtigley!,mhowell!

So wait. Does this mean the fix is in the next version of Firefox?

Attachment #9212818 - Attachment description: Bug 1611643 - Allow PiP to autoplay on Plex. r=mtigley!,mhowell! → WIP: Bug 1611643 - Allow PiP to autoplay on Plex. r=mtigley!,mhowell!
Attachment #9251697 - Attachment description: Bug 1611643 - added test case for running autoplayed videos on PiP. r=mtigley!,mhowell! → WIP: Bug 1611643 - added test case for running autoplayed videos on PiP. r=mtigley!,mhowell!
Attachment #9251697 - Attachment description: WIP: Bug 1611643 - added test case for running autoplayed videos on PiP. r=mtigley!,mhowell! → Bug 1611643 - added test case for running autoplayed videos on PiP. r=mtigley!,mhowell!

(In reply to OpenMySourceCode from comment #8)

So wait. Does this mean the fix is in the next version of Firefox?

Patches are currently still in review. But if we can get it approved and merged soon (before December 2), then we can get that fix in for Nightly. :)
(However, not until much later for Firefox release)

Attachment #9212818 - Attachment description: WIP: Bug 1611643 - Allow PiP to autoplay on Plex. r=mtigley!,mhowell! → Bug 1611643 - Allow PiP to autoplay on Plex. r=mtigley!,mhowell!
Attachment #9212818 - Attachment description: Bug 1611643 - Allow PiP to autoplay on Plex. r=mtigley!,mhowell! → WIP: Bug 1611643 - Allow PiP to autoplay on Plex. r=mtigley!,mhowell!
Attachment #9251697 - Attachment description: Bug 1611643 - added test case for running autoplayed videos on PiP. r=mtigley!,mhowell! → WIP: Bug 1611643 - added test case for running autoplayed videos on PiP. r=mtigley!,mhowell!

(In reply to kpatenio from comment #9)

(In reply to OpenMySourceCode from comment #8)

So wait. Does this mean the fix is in the next version of Firefox?

Patches are currently still in review. But if we can get it approved and merged soon (before December 2), then we can get that fix in for Nightly. :)
(However, not until much later for Firefox release)

Will it show on here when the patch is included in nightly?

Sorry for lack of updates here (and for not being able to get this landed soon). Had this ticket on my radar for a while, but sadly did not have a chance to work on it further after encountering run-ins with failing intermittent tests. I intend to revisit this patch soon and try to figure out why it's raising issues with tests on Windows.

There will be a notification here when the patch has landed. After that, in the next Nightly update, the patch should be included.

The bug assignee didn't login in Bugzilla in the last 7 months.
:mconley, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: katkoor2 → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(mconley)
Priority: -- → P3

Looks like kpatenio will come back around to this (see comment 11).

Flags: needinfo?(mconley)

Last time I tackled this (again), there were still issues with the test browser_resizeVideo.js on Windows builds. I recall the test only failing in headless mode when running locally on a Windows machine. Haven't had a chance to revisit this and figure out why (yet), for most of my focus lately has been on bug 1751505.

I have an issue on YouTube where, whenever the resolution of the video is changes due to connection issues, PiP is terminated. I think adding a mechanism like the one described here could resolve this as well.

See Also: → 1617125
Severity: normal → S3
Duplicate of this bug: 1723065
You need to log in before you can comment on or make changes to this bug.