1611645 - "Mozilla Firefox (Private Browsing)" tooltip appears when hovering over browser chrome in private windows, for example over urlbar search suggestions

Status: VERIFIED FIXED

(Firefox :: General, defect, P3)

Description

[Yaron]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

Open a private window.
Type "Firefox" in the UrlBar.
Hover over the search suggestions.

Actual results:

A "Mozilla Firefox (Private Browsing)" tooltip shows up.

Expected results:

This tooltip is distracting. Do not show it.

Comment 1

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Marco Bonardo [:mak]]

I cannot reproduce in Nightly on a Mac.
Is this with the update1 pref enabled in 72? does it happen without update1? it's possible the bug was fixed at a later time...
Also, search suggestions in pb windows are obviously enabled.

Comment 3

[Yaron]

(In reply to Marco Bonardo [:mak] from comment #2)

I cannot reproduce in Nightly on a Mac.
Is this with the update1 pref enabled in 72? does it happen without update1? it's possible the bug was fixed at a later time...
Also, search suggestions in pb windows are obviously enabled.

Can you please try it with 72?

The tooltip shows up whether "update1" is enabled or disabled.

Indeed, search suggestions in pb windows are enabled.
I started using the search functionality in the UrlBar in FF 71 when "Show search suggestions in private windows" was introduced

Thank you.

Comment 4

[Drew Willcoxon :adw]

I can reproduce this on 72 but not on 73 or Nightly. At this point it's too late to port a fix to 72, so I'll mark this as worksforme. If you can reproduce it on 73 or Nightly unlike me, please let us know.

Comment 5

[Yaron]

Great. Thank you (for that too :) ).

Comment 6

[Yaron]

I can reproduce it on FF 76.

Comment 7

[Yaron]

(In reply to Drew Willcoxon :adw from comment #4)

I can reproduce this on 72 but not on 73 or Nightly. At this point it's too late to port a fix to 72, so I'll mark this as worksforme. If you can reproduce it on 73 or Nightly unlike me, please let us know.

Can you please have a look? - I find this behavior quite annoying.
Thank you.

Comment 8

[Drew Willcoxon :adw]

Yes, I can reproduce this on the latest Nightly again. I can see how it can be annoying.

Comment 9

[Drew Willcoxon :adw]

The tooltip is shown for every element in chrome that doesn't have its own tooltip, not only the urlbar view, for example spacers in the toolbar or the urlbar input. Setting docElement.title is the problem: https://searchfox.org/mozilla-central/rev/fc91a093e40dde71d10ad219946b8ae775aca9eb/browser/base/content/browser.js#8238

I'm not sure why we're doing that. That code was added in bug 1602808: https://hg.mozilla.org/mozilla-central/rev/5db76e42440f772712bf596a267c03a89d6025d8

Before that, we didn't set title or anything: https://hg.mozilla.org/mozilla-central/annotate/510148b18effcf093100bd89e2f6eaf24c358a08/browser/base/content/browser.js#l8387

And before that, we set the "title" attribute, not the property: https://hg.mozilla.org/mozilla-central/annotate/9223ff1024a67d3d160b75481905a7079031223f/browser/base/content/browser.js#l8949

Setting the attribute has the same effect as setting the property. So maybe bug 1602808 reverted back to this older changeset but set the property instead of the attribute? That would explain why this appeared first, then was fixed, and now is broken again.

Anyway, the window ends up with the correct title (via tabbrowser.updateTitlebar and getWindowTitleForBrowser), so it doesn't seem necessary to set the title on the document element.

Comment 10

[Drew Willcoxon :adw]

Attachment: Bug 1611645 - Don't set documentElement.title in private windows.

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1611645#c9 for a
summary.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9259663203fe
Don't set documentElement.title in private windows. r=Gijs

Comment 12

[Yaron]

Thank you. I appreciate it.

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9259663203fe

Comment 14

[Alexandru Trif, QA [:atrif]]

Reproduced the issue using Firefox 78.0a1 (20200522213853) on Windows 10x64.
The issue is verified fixed with Firefox 78.0b7 (20200612174529) on Windows 10x64, macOS 10.12 and Ubuntu 18.04. No search tip is displayed in private windows when hovering search results.