1611666 - Search field keeps cutting off letters while typing

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect)

Description

[Francesco Lodolo [:flod]]

The search field seems too eager to start a search. Way too often, when I type something in the search field, it ends up in a jumbled state, because in the meantime a search provided results, and the search input seems to be reset to the content available when the search was triggered.

For example, it happens basically every time I search for %1$S, where the special characters require to use SHIFT on my keyboard, and so a bit more time to type than a normal character. So, I might end up with "%$S", "%1S", etc.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: GIF of Pontoon search

Comment 2

[Matjaz Horvat [:mathjazz]]

I wonder if we should require Enter to trigger search, like we do in the Machinery.

Comment 3

[Francesco Lodolo [:flod]]

I assume there's a delay before starting the search. What's the current value? Maybe a start is to increment it.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1569

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

adngdb merged PR #1569: "Fix bug 1611666 - Prevent loss of letters while typing in the search …" in 0a35cb4.