1611682 - "Show DOM properties" is broken

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Sören Hentzschel]

STR:

1. open the inspector in the browser toolbox
2. right click on a element
3. select the "show DOM properties" item

Expected:

The feature works.

Actual:

Nothing happens.

It's a regression from bug 1609345.

12:38.51 INFO: No more inbound revisions, bisection finished.
12:38.51 INFO: Last good revision: 4bb4b4682c2d625f72c41e342579ea9c8cbde811
12:38.51 INFO: First bad revision: d889627c1bf5c6bce0c41256dbd0a0b1ff5e5074
12:38.51 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4bb4b4682c2d625f72c41e342579ea9c8cbde811&tochange=d889627c1bf5c6bce0c41256dbd0a0b1ff5e5074

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Regular toolbox is impacted as well.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

the issue is that inspect is used for 2 different things:

• jump to the inspector when the user use it with a node in the console
• expand the OI in the console for the element the user chose Show DOM properties on

since we made a change in how we deal with inspect to always jump to the debugger, now we are missing the "Show properties" part.
One quick fix is to use console.dir instead of inspect for this. This isn't perfect as the expression result will print an undefined.
We could maybe try to use a logInPage method instead, which wouldn't use an actual console evaluation (i.e. there won't be the inspect($0) command).
I'm probably going to investigate this as it seems cleaner for the users.

In the end, we should probably have a properties sidepanel in the inspector instead of abusing the console to do this, but that's another story.

Comment 3

[Pascal Chevrel:pascalc]

Nicolas, do you think that you will have a fix before merge day on Feb 10? Thanks

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

yes, the patch is sitting on my computer, will send it soon. Thanks for the reminder!

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1611682 - Fix show DOM properties. r=rcaliman.

This patch work around the fact that the inspect command
is used for different purpose:

• open the evaluated element in the inspector/debugger
• expand a given object in the console

In order to do that, a second parameter is added to indicate
which usage we do want.
This is not pretty, but I can't see something as straightforward
to fix this issue.
Given that there's plan to have a properties sidebar in the
inspector, it might be enough for now.

The existing test is modified to check that the object is indeed
expanded in the console.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bb59b3a8d70
Fix show DOM properties. r=rcaliman.

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/3bb59b3a8d70