1611690 - Send tab to device not triggering master password anymore and not sending tabs

Status: VERIFIED FIXED

(Firefox :: Sync, defect, P1)

Description

[Albert Scheiner [:alberts]]

Prerequisite

Firefox with

• master password set
• sync enabled
• other devices syncing as well to have a list of at least one device to send to
• Add "Send Tab to Device" to address bar (via "..." in address bar) to show icon (that's just how I set it up really)

Steps

• restart Firefox
• in case a master password prompt comes up, close it for now (e.g. hit esc)
• trigger "send tab" from address bar icon

Expected

The master password comes up to enable the tab syncing.

Actual

Several weeks ago this behaviour stopped. Now the device list comes up directly and can be clicked, but the tab does not get sent.

Work around

The master password has to be trigger differently* and filled in first, before tabs can be sent.

*for example: Toolbar > Firefox Account icon > "Sync now"

Comment 1

[Mark Hammond [:markh] [:mhammond]]

I'm actually surprised that it used to work as you describe - ie, that if sync showed a master-password prompt which you cancelled, send-tab would show it again.

Regardless, now that it is possible to be signed in to an account but not be using Sync, I think the user is going to have a bad time if a master password is enabled - we should always prompt when trying to send a tab.

Comment 2

[Albert Scheiner [:alberts]]

Hi Mark, it is working for me in Dev Edition (73), but failing in Nightly (74). I think you should be able to test it with those two versions atm.

Comment 3

[Albert Scheiner [:alberts]]

Attachment: send-tab-icon-in-address-bar.png

Clicking that icon triggers master password dialog in FF73 if the MP hasn't been entered yet, before revealing the list of linked devices. In 74 this is no longer the case, but instead the list is shown, but clicking an item does not trigger the send action.

Comment 4

[Albert Scheiner [:alberts]]

I can confirm, that after upgrading my Developer Edition to 74.0b2 this now happens there as well.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Before bug 1604699, we did a quick sync of the clients collection as this feature was used. Since that bug we no longer do that and rely just on FxA. I suspect that's what causes this regression.

Comment 6

[Edouard Oger [:eoger]]

I don't think the master-password prompt was intentional in any case, so I suggest closing as WONTFIX.

Comment 7

[Mark Hammond [:markh] [:mhammond]]

(In reply to Edouard Oger [:eoger] from comment #6)

I don't think the master-password prompt was intentional in any case, so I suggest closing as WONTFIX.

I believe that if the master password is locked, the send tab UI silently fails to work. I don't think we can just leave it like that, do you?

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1611690 - sending a tab now prompts for a master-password. r?eoger

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ad2c3dc881d
sending a tab now prompts for a master-password. r=eoger

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5ad2c3dc881d

Comment 11

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 9127762 [details]
Bug 1611690 - sending a tab now prompts for a master-password. r?eoger

Beta/Release Uplift Approval Request

• User impact if declined: Users with an unlocked master password are unable to send tabs
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Limited to sending tabs
• String changes made/needed:

Comment 12

[Albert Scheiner [:alberts]]

Thanks! I can also confirm that this works again. \o/
Just an FYI, before the masterpw prompt came before the list of devices opened, now it triggers when clicking one of the listed options. This is just meant as a note in case anyone asks.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9127762 [details]
Bug 1611690 - sending a tab now prompts for a master-password. r?eoger

Verified by the reporter in Nighty but I'd like it to be verified by our QA in Beta after the uplift, since we have STR in comment #0, uplift approved for 74.0b7, thanks.

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/bbb401c66a04

Comment 15

[Daniel Kolsis]

Verified - Fixed - checked on the latest Nightly and Beta 74.0b7 (25.02.2020).