Closed Bug 1611718 Opened 5 years ago Closed 5 years ago

Retain the about:logins search bar position when the branding is not official

Categories

(Firefox :: about:logins, enhancement)

enhancement
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 74
Tracking Status
firefox74 --- verified
firefox76 --- verified
firefox77 --- verified
firefox78 --- verified

People

(Reporter: itiel_yn8, Assigned: itiel_yn8)

Details

Attachments

(2 files)

Attached image Screenshot

See attached. Reproducible when running locally.
Currently the search bar simply shifts to to the left.

Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/d6dab3f29fd1 Retain the about:logins search bar position when the branding is not official r=MattN
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74

@Itiel, I can't locally build firefox and is there any way we can verify this issue without the use of local builds?

Flags: needinfo?(itiel_yn8)

(In reply to Simona Rosu [:srosu], Ecosystem QA from comment #4)

@Itiel, I can't locally build firefox and is there any way we can verify this issue without the use of local builds?

Sure:

  1. On Nightly open about:logins
  2. Inspect the page (Ctrl+Shift+C, if you're on Windows)
  3. On the HTML markup section, find the <html> tag at the beginning
  4. On that tag, double click on the "official-branding" part and remove it, press Enter
  5. You should now be able to see that the "Firefox Lockwise" logo is removed, and the searchbox has retained its position, while in a build from 3 months ago it's shifted to the beginning of the page.

Note that reloading the page will reset everything, which is normal as the "official-branding" part will be back after reloading.

Flags: needinfo?(itiel_yn8) → needinfo?(srosu)

Thank you very much for your reply, it helped me with verifying the fix and the issue is not reproducible anymore.
I have verified using the Firefox Nightly 78.0a1 (Build ID: 20200508093543), Firefox Beta 77.0b3 (Build ID: 20200507233245), Firefox Release 76.0 (Build ID: 20200429185419), Firefox Nightly 74.0a1 (Build ID: 20200127213955) on Windows 10 x64, Ubuntu 18.04 x64, and Mac 10.15.4.

  • The search bar position remains the same when the brand name does not exist.
Status: RESOLVED → VERIFIED
Flags: needinfo?(srosu)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: