Closed Bug 1611818 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 21439 - [css-pseudo] Don't update non-normal markers if list-style-type changes

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21439 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21439
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-pseudo] Don't update non-normal markers if list-style-type changes

If a ::marker has the 'content' property set to something different than
'normal', then the contents of the marker should be determined according
to that value, not from 'list-style-type'.

Before this patch, the behavior was already correct when laying out the
marker for the first time. But if 'list-style-type' changed afterwards,
the marker was updated to reflect the new value, ignoring 'content'.

BUG=457718

TEST=external/wpt/css/css-pseudo/marker-content-021.html

The test fails in legacy since 'content' is not supported yet.

Change-Id: Id845774739927c9c574a66e9d1cc94e6ea59d5e5

Reviewed-on: https://chromium-review.googlesource.com/2020957
WPT-Export-Revision: 63bf3cca65007a40053391cec2f28116eac21476

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f016eef56a2
[wpt PR 21439] - [css-pseudo] Don't update non-normal markers if list-style-type changes, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.