Closed Bug 1611820 Opened 5 years ago Closed 5 years ago

Minimize time spent loading modules in chromeutils.import when starting a first-time load

Categories

(GeckoView :: General, defect, P1)

Unspecified
All
defect

Tracking

(Performance Impact:high)

RESOLVED FIXED
Performance Impact high

People

(Reporter: jesup, Assigned: bdahl)

References

Details

(Keywords: perf:pageload, Whiteboard: [geckoview:m75][geckoview:m76][geckoview:m77])

When loading a URL in a new process in geckoview, a long time is spent importing modules and also running loadURIDelegate (and spinning the event loop waiting on the master process). See https://perfht.ml/2GsFALO

Priority: -- → P1
Whiteboard: [qf:p1:pageload] → [qf:p1:pageload][geckoview:m75]
Assignee: nobody → bdahl

Randell,
What were your steps to produce this profile?

Locally on gecko view example, if I open a new tab I see GV import a number modules, but if I navigate to a new URL there aren't that many modules that are loaded. Also, on that profile there appears to be a good chunk of time spent loading devtools (which is not loaded regularly).

Flags: needinfo?(rjesup)

Per comment 0, this is for loading into a new process in geckoview, which means a (re)start of Fenix, or a restart of the geckoview content process after it's been killed due to mem pressure.

It is loading devtools stuff; I don't know if that's due to the fact that we're capturing a profile remotely. If it isn't, then that's definitely something we'd want to avoid/defer loading.

Flags: needinfo?(rjesup)
Whiteboard: [qf:p1:pageload][geckoview:m75] → [qf:p1:pageload][geckoview:m75][geckoview:m76]
Whiteboard: [qf:p1:pageload][geckoview:m75][geckoview:m76] → [qf:p1:pageload][geckoview:m75][geckoview:m76][geckoview:m77]
Depends on: 1619798

Closing since the loadURIDelegate changes landed and the startup cache should be working more consistently to help with module load time now (bug 1624724).

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Performance Impact: --- → P1
Keywords: perf:pageload
Whiteboard: [qf:p1:pageload][geckoview:m75][geckoview:m76][geckoview:m77] → [geckoview:m75][geckoview:m76][geckoview:m77]
You need to log in before you can comment on or make changes to this bug.