1611886 - Add VRManagerParent::Shutdown()

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

Created by Bug 1605251 Comment 10.

VRManagerParent does not have Shutdown() like ImageBridgeParent::Shutdown(). ImageBridgeParent::Shutdown() is used for forcibly close IPC of ImageBridgeParents.

https://searchfox.org/mozilla-central/rev/cbd110d718bc89a499d3f996af24532abbf6f8ea/gfx/layers/ipc/ImageBridgeParent.cpp#135
https://searchfox.org/mozilla-central/rev/cbd110d718bc89a499d3f996af24532abbf6f8ea/gfx/layers/ipc/ImageBridgeParent.cpp#115

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1611886 - Add VRManagerParent::Shutdown()

Comment 2

[Sotaro Ikeda [:sotaro]]

Current patch causes test failures.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e110c44987c40681b16940b1c5de0fa2df944fc

Comment 3

[Sotaro Ikeda [:sotaro]]

Updated patch addressed some failures.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=19c0aa36f16b1c2edacc39490d2ffc6870fcfad0

Comment 4

[Sotaro Ikeda [:sotaro]]

Addressed test failures.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=00ae5d096c4b829d626c53418edd09ccd252c485

Comment 5

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=14fe48d28a830293388a6181068179a78464f07b

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a91870b97f09
Add VRManagerParent::Shutdown() r=nical

Comment 7

[Cristian Brindusan [:cbrindusan]]

Backed out changeset a91870b97f09 (Bug 1611886) for xpcshell failures at test_browserid_identity.js.
https://hg.mozilla.org/integration/autoland/rev/10059adf004590aca187aab75d0e46a6cfde1e44

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=a91870b97f09246590f093074ce31531ed531354&selectedJob=288313351

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=288313351&repo=autoland&lineNumber=2808

Comment 8

[Sotaro Ikeda [:sotaro]]

It seems that VRManagerParent::ShutdownInternal() does not handle a case that VRManager::ManagerInit() is not called.

Comment 9

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20297284e29a86ce6b85441e20842f13031c378e

Comment 10

[Sotaro Ikeda [:sotaro]]

Test failure is addressed.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=51c9ca7378ee0a0003c81ecc2114629853eb61a7

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4349043df363
Add VRManagerParent::Shutdown() r=nical

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4349043df363