1611895 - Crash in [@ mozilla::EditorEventListener::DragOverOrDrop]

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[Julien Cristau [:jcristau]]

A few of these crashes near null in nightly starting January 25.

This bug is for crash report bp-3f8d86c9-aaaf-4600-9eaf-f77850200127.

Top 10 frames of crashing thread:

0 xul.dll mozilla::EditorEventListener::DragOverOrDrop editor/libeditor/EditorEventListener.cpp:756
1 xul.dll mozilla::EditorEventListener::HandleEvent editor/libeditor/EditorEventListener.cpp:336
2 xul.dll mozilla::HTMLEditorEventListener::HandleEvent editor/libeditor/HTMLEditorEventListener.cpp:98
3 xul.dll mozilla::EventListenerManager::HandleEventSubType dom/events/EventListenerManager.cpp:1078
4 xul.dll mozilla::EventListenerManager::HandleEventInternal dom/events/EventListenerManager.cpp:1270
5 xul.dll mozilla::EventTargetChainItem::HandleEvent dom/events/EventDispatcher.cpp:356
6 xul.dll static mozilla::EventTargetChainItem::HandleEventTargetChain dom/events/EventDispatcher.cpp:594
7 xul.dll static mozilla::EventTargetChainItem::HandleEventTargetChain dom/events/EventDispatcher.cpp:638
8 xul.dll static mozilla::EventDispatcher::Dispatch dom/events/EventDispatcher.cpp:1055
9 xul.dll mozilla::PresShell::EventHandler::DispatchEventToDOM layout/base/PresShell.cpp:8281

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, regression of bug 1610264.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1611895 - Make `EditorEventListener::DragOverOrDrop()` check whether the result of `DragEvent::GetRangeParentContentAndOffset()` returned `nullptr` or not r=smaug!

DragEvent::GetRangeParentContentAndOffset() may return nullptr. Previously,
it was checked and returned NS_ERROR_FAILURE before landing bug 1610264.

This patch adds the null check which was accidentally removed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/019ae805259f
Make `EditorEventListener::DragOverOrDrop()` check whether the result of `DragEvent::GetRangeParentContentAndOffset()` returned `nullptr` or not r=smaug

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/019ae805259f