1611953 - Implement RTCDataChannel.onclosing

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1611953: Enable test-cases for onclosing. r?jib

Depends on D261654

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1611953: Implement onclosing. r?ng!,#webidl!

Depends on D261657

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5997b39e17ad
https://hg.mozilla.org/integration/autoland/rev/566b99f081bd
Enable test-cases for onclosing. r=jib
https://github.com/mozilla-firefox/firefox/commit/9f5656272d7f
https://hg.mozilla.org/integration/autoland/rev/1e7908cec5c4
Implement onclosing. r=ng,webidl,smaug

Comment 4

[Atila Butkovits]

Backed out for causing failures at test_worker_interfaces_secureContext.html.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/5db718a758debc4f6ebd8f04b27bfd2b406b8823

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d6d506d58c9126587cddc8a47f10d2784bf8a56b&selectedTaskRun=WKwvrTx3Rl2y_FaorXLx4g.0

Failure logs:

https://treeherder.mozilla.org/logviewer?job_id=525771908&repo=autoland&task=JKnsAyA4SBSczZ26x4JMMQ.0&lineNumber=152194
https://treeherder.mozilla.org/logviewer?job_id=525783176&repo=autoland&task=LWLwDZHSSFq5Dg_yLvQ-jA.0&lineNumber=8114
https://treeherder.mozilla.org/logviewer?job_id=525771868&repo=autoland&task=CrcZPImbQGOggcThlbi41w.0&lineNumber=20926

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/92af49035698
https://hg.mozilla.org/integration/autoland/rev/d86e3e74e837
Enable test-cases for onclosing. r=jib
https://github.com/mozilla-firefox/firefox/commit/6ef5c01f9d6a
https://hg.mozilla.org/integration/autoland/rev/4d0c43575688
Implement onclosing. r=ng,webidl,smaug

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ TestStopGapEventTarget.cpp

Backout link: https://github.com/mozilla-firefox/firefox/commit/9a817cb4a482fcbc946173c9d42ec2d530dbad72

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/xpcom/tests/gtest/TestStopGapEventTarget.cpp:25:37: error: unknown class name 'CancelableRunnable'; did you mean 'mozilla::CancelableRunnable'?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/547c85cd2741
https://hg.mozilla.org/integration/autoland/rev/e25fb86fea05
Enable test-cases for onclosing. r=jib
https://github.com/mozilla-firefox/firefox/commit/0fdf668f069b
https://hg.mozilla.org/integration/autoland/rev/c4a3023c2b72
Implement onclosing. r=ng,webidl,smaug

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e25fb86fea05
https://hg.mozilla.org/mozilla-central/rev/c4a3023c2b72

Comment 9

[Donal Meehan [:dmeehan]]

:bwc, is there anything you want to mention in a release note? (Process info)

Comment 10

[Byron Campen [:bwc]]

I'm not sure if this merits a release note, I don't think many actually use this. Bug 1209163 is definitely worth mentioning though. I'll go ahead and request that.

Comment 11

[Hamish Willee]

FF144 MDN docs work for this can be tracked/viewed in https://github.com/mdn/content/issues/41135