1611965 - Add support for the new `all` value to text-decoration-skip-ink

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, enhancement, P3)

Description

[Jonathan Kew [:jfkthame]]

This has recently been added to the spec.

Note that there are suggestions that the new value should be all rather than always; we need to get the WG to confirm the name before we ship it. (Personally, I agree that all would be better.)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1611965 - Add support for the 'all' value of text-decoration-skip-ink. r=emilio

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1611965 - Add example with 'all' to WPT text-decoration-skip-ink tests. r=emilio

Depends on D61184

Comment 3

[Jonathan Kew [:jfkthame]]

(Patch is currently written assuming the new value is always; if we can get the WG to agree to all instead I'll update accordingly.)

Comment 4

[Jonathan Kew [:jfkthame]]

The WG has just resolved to use all here, so I will adjust the patch accordingly.
https://github.com/w3c/csswg-drafts/issues/4277#issuecomment-588354602

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a324be891093
Add support for the 'all' value of text-decoration-skip-ink. r=emilio
https://hg.mozilla.org/integration/autoland/rev/3ab471678cbd
Add example with 'all' to WPT text-decoration-skip-ink tests. r=emilio

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21888 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/a324be891093
https://hg.mozilla.org/mozilla-central/rev/3ab471678cbd

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Janet Swisher]

Added a definition of all to text-decoration-skip-ink and added lines to the live example to demo all. Not adding it to the interactive example, as I don't know if it's supported in other browsers.

Updates to the BCD and formal syntax box are forthcoming.