Closed Bug 1611965 Opened 5 years ago Closed 5 years ago

Add support for the new `all` value to text-decoration-skip-ink

Categories

(Core :: Layout: Text and Fonts, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

This has recently been added to the spec.

Note that there are suggestions that the new value should be all rather than always; we need to get the WG to confirm the name before we ship it. (Personally, I agree that all would be better.)

Assignee: nobody → jfkthame
Status: NEW → ASSIGNED

(Patch is currently written assuming the new value is always; if we can get the WG to agree to all instead I'll update accordingly.)

The WG has just resolved to use all here, so I will adjust the patch accordingly.
https://github.com/w3c/csswg-drafts/issues/4277#issuecomment-588354602

Summary: Add support for the new `always` value to text-decoration-skip-ink → Add support for the new `all` value to text-decoration-skip-ink
Attachment #9123330 - Attachment description: Bug 1611965 - Add support for the 'always' value of text-decoration-skip-ink. r=emilio → Bug 1611965 - Add support for the 'all' value of text-decoration-skip-ink. r=emilio
Attachment #9123331 - Attachment description: Bug 1611965 - Add example with 'always' to WPT text-decoration-skip-ink tests. r=emilio → Bug 1611965 - Add example with 'all' to WPT text-decoration-skip-ink tests. r=emilio
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a324be891093 Add support for the 'all' value of text-decoration-skip-ink. r=emilio https://hg.mozilla.org/integration/autoland/rev/3ab471678cbd Add example with 'all' to WPT text-decoration-skip-ink tests. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21888 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Upstream PR merged by moz-wptsync-bot
Summary: Add support for the new `all` value to text-decoration-skip-ink → Add support for the new `always` value to text-decoration-skip-ink
Summary: Add support for the new `always` value to text-decoration-skip-ink → Add support for the new `all` value to text-decoration-skip-ink

Added a definition of all to text-decoration-skip-ink and added lines to the live example to demo all. Not adding it to the interactive example, as I don't know if it's supported in other browsers.

Updates to the BCD and formal syntax box are forthcoming.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: