Closed Bug 1612004 Opened 6 years ago Closed 5 years ago

ClientOpenWindowInCurrentProcess uses outparam before checking rv

Categories

(Core :: DOM: Service Workers, defect, P2)

Product:
Core
Component:
DOM: Service Workers
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: bzbarsky, Unassigned)

References

(Regression)

Details

(Keywords: regression)

See https://searchfox.org/mozilla-central/rev/ad6234148892bc29bf08d736604ac71925138040/dom/clients/manager/ClientOpenWindowUtils.cpp#419,421,423

If rv is failure, won't bc be null and hence we will crash?

Flags: needinfo?(kmaglione+bmo)

I assume, this is not a ServiceWorker related issue.

Component: DOM: Service Workers → DOM: Core & HTML

The code in question is part of the implementation of https://w3c.github.io/ServiceWorker/#clients-openwindow

Component: DOM: Core & HTML → DOM: Service Workers

I see, thanks.

Priority: -- → P2

AFAICT, the function ClientOpenWindowInCurrentProcess has been removed with some Fission related refactoring, and I did not spot any similar code snippet any more.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(kmaglione+bmo)
Resolution: --- → WORKSFORME
Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.