1612007 - Add convenient methods for throwing DOMExceptions on ErrorResult

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Things like ThrowSyntaxError, etc. Nika suggested this today.

In the new setup you can do: aRv.ThrowSyntaxError("you typed it wrong").

We can convert existing ThrowDOMException uses to these, then make ThrowDOMException private...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Note that we are getting pretty close to just being able to create our DOMExceptions without an nsresult at all. Once everyone is switched to the new accessors, might be worth doing that, perhaps.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1612007. Add convenience methods for throwing various spec-defined DOMExceptions on ErrorResult. r=smaug

Comment 3

[Boris Zbarsky [:bzbarsky]]

And fwiw, we only have ~100 ThrowDOMException callsites, and can convert them to this new thing pretty easily...

Comment 4

[Boris Zbarsky [:bzbarsky]]

Note that we are getting pretty close to just being able to create our DOMExceptions without an nsresult at all.

Though that might be slower, because then it will look up the nsresult by name....

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70615b052db5
Add convenience methods for throwing various spec-defined DOMExceptions on ErrorResult.  r=smaug

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/70615b052db5