Closed Bug 1612079 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21487 - Make sure layout is triggered when changing clip-path resource

Categories

(Core :: Web Painting, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21487 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21487
Details from upstream follow.

Fredrik Söderquist <fs@opera.com> wrote:

Make sure layout is triggered when changing clip-path resource

When changing the 'clip-path' property on an (SVG) element we need to
recompute the visual rect since it includes contributions from the clip
bounds (as well as the mask and filter bounds). This wasn't happening,
which meant that the element wouldn't repaint properly if the old bounds
were smaller than the new bounds.
Add some detection of bounds-affecting changes to SVGResourcesCache and
Make use of that in SVGResourcesCache::ClientStyleChanged() to mark the
element for layout if needed so that its bounds are updated properly.

Fixed: 1045915
Change-Id: Ia08904945b26c382e0b9c90c15b7cc45d40434cb
Reviewed-on: https://chromium-review.googlesource.com/2023561
WPT-Export-Revision: 9458d071b44eefaed7b2318ac53e240852efce90

Component: web-platform-tests → Web Painting
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e5bd74fa1d3
[wpt PR 21487] - Make sure layout is triggered when changing clip-path resource, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.