1612147 - RefPtr<FeaturePolicy> is stored in BrowsingContext

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P1)

Description

[Andreas Farre [:farre]]

Mutable datatypes cannot be stored in BrowsingContext since that won't be synced.

Also, FeaturePolicy in BrowsingContext syncs principals, which is not correct.

Comment 1

[Andreas Farre [:farre]]

Attachment: Bug 1612147 - Don't store FeaturePolicy in BrowsingContext. r=smaug

It's not possible to stora a value with mutable data in a
BrowsingContext synced field (in this case a RefPtr<T>), since this
will bypass syncing when written to. Instead store FeaturePolicyInfo
as a value.

We also wish to avoid storing nsIPrincipals in the ContentChild, since
we might be leaking information about a document from another domain
and process in the fission case. Instead initialize FeaturePolicy with
NullPrincipals when creating them from a BrowsingContext representing
an oop document.

Comment 2

[Neha Kochar [:neha]]

Andreas said this needs to be owned by someone who knows Feature Policy better and Andreas will be available for Fission questions and help.

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Putting in the backlog for now till baku answers.

Comment 4

[Andrea Marchesini [:baku]]

Sorry for the delay. I just accepted the Farre's patch.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:farre, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Andreas Farre [:farre]]

I've rebased it, but I also changed the call to FeaturePolicy::SetDeclaredPolicy in FeaturePolicyUtils::FromBrowsingContext to pass a nullptr for src. I think that's more correct. Does that sound reasonable Baku?

Comment 7

[Christoph Kerschbaumer [:ckerschb]]

Setting the blocking review flag for baku in phab and following up on slack.

Comment 8

[Neha Kochar [:neha]]

This doesn't need to block M6b but needs to be done very soon in M6c.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/376c2ff62872
Don't store FeaturePolicy in BrowsingContext. r=smaug

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/376c2ff62872