1612198 - Remove NO_COMPONENTS_MANIFEST build variable

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Paul Morris [:pmorris]]

Working with the build system for Thunderbird in bug 1608610, I removed the only instance of a "NO_COMPONENTS_MANIFEST" build variable. Philipp Kewisch asked me to file this bug to have this variable removed from the build system, since it appears unused and no longer actually supported.

Where it is documented:
https://firefox-source-docs.mozilla.org/build/buildsystem/mozbuild-symbols.html#no-components-manifest

Search for it on searchfox:
https://searchfox.org/comm-central/search?q=NO_COMPONENTS_MANIFEST&case=false&regexp=false&path=

Comment 1

[Nathan Froyd [:froydnj]]

Thank you for filing this! Once bug 1608610 lands, would you mind writing a patch against mozilla-central to remove it, by deleting these lines:

https://searchfox.org/comm-central/source/mozilla/python/mozbuild/mozbuild/frontend/context.py#2342-2346

?

Comment 2

[Paul Morris [:pmorris]]

Sure, will do.

Comment 3

[Paul Morris [:pmorris]]

Attachment: Bug 1612198 - Remove last remnants of `NO_COMPONENTS_MANIFEST` build variable.

Comment 4

[Paul Morris [:pmorris]]

OK, I have submitted a patch via Phabricator. I didn't know who to request for review so I left that out. Will an appropriate person please review?

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:pmorris, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Paul Morris [:pmorris]]

I'm not that familiar with the process for landing patches on mozilla-central and Phabricator. I just read the docs and it looks like I needed to set the "checkin-needed" tag. I've done that now.

Since I work on comm-central, I'm not really set up to build mozilla-central or do try runs for it. Is that needed for this patch, which is quite low risk? Let me know if that's needed in this case and I can figure out how to adjust my set up to do it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/605eaa38210a
Remove last remnants of `NO_COMPONENTS_MANIFEST` build variable. r=dmajor

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/605eaa38210a