1612363 - window.close does not work for extension popups

Status: RESOLVED FIXED

(GeckoView :: Extensions, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

Extension popups can be closed using window.close, this however does not currently work on GeckoView.

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Going on PTO for a week so unassigning this. We looked briefly at it with :snorp, normally windows are not allowed to close themselves, but extension popups have special permissions that let them do so. We're not entirely sure how this is done on desktop, but the work here is figure out which flag allows popups to close themselves and apply it to our popups, probably here: https://searchfox.org/mozilla-central/rev/2e355fa82aaa87e8424a9927c8136be184eeb6c7/mobile/android/chrome/geckoview/geckoview.js#204

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Screenshot 2020-02-01 at 9.20.28 AM.png

This can be tested by loading uBlock on GVE and clicking on one of the buttons on the popup (see screenshot). Right now nothing happens (and an error is printed in the browser console), after the fix for this bug the app should get a call to ContentDelegate#onCloseRequest. Note that GVE doesn't listen to this event for popups yet, so that needs to be added too.

Comment 3

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1612363 - add ability to allow extensions to close their action popups in GV; r?snorp

add ability to allow extensions to close their action popups in GV.
also drive-by fix a call to a non-existent BrowserApp.selectTab function (which was evidently not ported from Fennec).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cfc30212a8a
add ability to allow extensions to close their action popups in GV; r=esawin,agi

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5cfc30212a8a