1612399 - `text-combine-upright` should not have any effect in sideways-* writing modes

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P3)

Description

[Jonathan Kew [:jfkthame]]

text-combine-upright:all should only have an effect in vertical writing modes, per https://drafts.csswg.org/css-writing-modes-3/#text-combine-upright. This should not include the sideways-rl and sideways-lr modes, where the text is actually in horizontal typographic mode, just rotated 90°.

Therefore, in a testcase like

data:text/html,<div lang="ja" style="writing-mode:sideways-rl">ABC<span style="text-combine-upright:all">123</span>XYZ

the span "123" should not be rotated and compressed to appear horizontally.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1612399 - Don't apply text-combine-upright in sideways-* writing modes. r=emilio

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21530 for changes under testing/web-platform/tests

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e574548c824
Don't apply text-combine-upright in sideways-* writing modes. r=emilio

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2e574548c824

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot