1612420 - [wpt-sync] Sync PR 21519 - Use parseFloat() to parse CSS pixels values in two WPT

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21519 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21519
Details from upstream follow.

Xiaocheng Hu <[e-mail]> wrote:

Use parseFloat() to parse CSS pixels values in two WPT

Two WPT use CSSNumericValue.parse() to parse CSS pixel values, which
makes the tests basically Chrome-only. This patch changes them to use
parseFloat() directly so that other browsers can pass.

Bug: 441925
Change-Id: I01d6d2999cf4266bd6d3bda521d2bdfc8732ab7c
Reviewed-on: https://chromium-review.googlesource.com/2031932
WPT-Export-Revision: a262143ee2a0a4584b9d855292a39a10882e5c5e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5a73da606bcde73854f516a4142da0080900da1

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 45 tests

Status Summary

Firefox

OK : 2
PASS: 4[GitHub] 47[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 4

Chrome

OK : 2
PASS: 8

Safari

OK : 2
PASS: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-values/ch-pseudo-recalc-on-font-load.html
ch in pseudo-element ::after should be recalculated after loading a web font: FAIL
ch in pseudo-element ::marker should be recalculated after loading a web font: FAIL
ch in pseudo-element ::before should be recalculated after loading a web font: FAIL
ch in pseudo-element ::first-line should be recalculated after loading a web font: FAIL

New Tests That Don't Pass

/css/css-values/ch-pseudo-recalc-on-font-load.html
ch in pseudo-element ::after should be recalculated after loading a web font: FAIL (Chrome: PASS, Safari: PASS)
ch in pseudo-element ::marker should be recalculated after loading a web font: FAIL (Chrome: PASS, Safari: PASS)
ch in pseudo-element ::before should be recalculated after loading a web font: FAIL (Chrome: PASS, Safari: PASS)
ch in pseudo-element ::first-line should be recalculated after loading a web font: FAIL (Chrome: PASS, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0129e775fc4
[wpt PR 21519] - Use parseFloat() to parse CSS pixels values in two WPT, a=testonly
https://hg.mozilla.org/integration/autoland/rev/91f337789ee1
[wpt PR 21519] - Update wpt metadata, a=testonly

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e0129e775fc4
https://hg.mozilla.org/mozilla-central/rev/91f337789ee1