1612427 - Intermittent browser/components/customizableui/test/browser_947914_button_zoomReset.js | Button displays the correct zoom level - Got 100, expected 50

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Treeherder Bug Filer]

Filed by: dvarga [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=286999580&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/EdpxUHnaR3ep717Lt7uYmQ/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-01-30T16:58:08.737Z] 16:58:08     INFO - TEST-PASS | browser/components/customizableui/test/browser_947914_button_zoomReset.js | Page zoom reset correctly - 
[task 2020-01-30T16:58:08.737Z] 16:58:08     INFO - Buffered messages finished
[task 2020-01-30T16:58:08.738Z] 16:58:08     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_947914_button_zoomReset.js | Button displays the correct zoom level - Got 100, expected 50
[task 2020-01-30T16:58:08.738Z] 16:58:08     INFO - Stack trace:
[task 2020-01-30T16:58:08.738Z] 16:58:08     INFO - chrome://mochikit/content/browser-test.js:test_is:1320
[task 2020-01-30T16:58:08.738Z] 16:58:08     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_947914_button_zoomReset.js:null:35
[task 2020-01-30T16:58:08.738Z] 16:58:08     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1062
[task 2020-01-30T16:58:08.738Z] 16:58:08     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2020-01-30T16:58:08.738Z] 16:58:08     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:925
[task 2020-01-30T16:58:08.738Z] 16:58:08     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:808
[task 2020-01-30T16:58:08.738Z] 16:58:08     INFO - Menu panel was closed
[task 2020-01-30T16:58:08.738Z] 16:58:08     INFO - Leaving test bound 
[task 2020-01-30T16:58:08.739Z] 16:58:08     INFO - Entering test bound asyncCleanup
[task 2020-01-30T16:58:08.739Z] 16:58:08     INFO - Zoom level was restored
[task 2020-01-30T16:58:08.739Z] 16:58:08     INFO - Leaving test bound asyncCleanup
[task 2020-01-30T16:58:08.739Z] 16:58:08     INFO - GECKO(6908) | MEMORY STAT | vsize 2104333MB | vsizeMaxContiguous 65131042MB | residentFast 415MB | heapAllocated 212MB
[task 2020-01-30T16:58:08.739Z] 16:58:08     INFO - TEST-OK | browser/components/customizableui/test/browser_947914_button_zoomReset.js | took 394ms
[task 2020-01-30T16:58:08.739Z] 16:58:08     INFO - checking window state

Comment 1

[Intermittent Failures Robot]

1 failures in 2190 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform breakdown:

• windows10-64-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1612427&startday=2020-01-27&endday=2020-02-02&tree=all

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit auto_nag documentation.

Comment 3

[Oana Pop-Rus]

Recent failure log:https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299045690&repo=autoland&lineNumber=32717

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1612427 - Fix flaky browser_947914_button_zoomReset.js. r=Gijs

This is what I see when running the test:

console.log: Changing zoom for browser from 1 to 0.5
set fullZoom@chrome://global/content/elements/browser-custom-element.js:812:19
set fullZoom@chrome://browser/content/tabbrowser.js:526:7
ZoomManager_setZoomForBrowser@chrome://global/content/viewZoomOverlay.js:60:7
set zoom@chrome://global/content/viewZoomOverlay.js:49:10
@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_947914_button_zoomReset.js:26:5
Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1039:34
Tester_execTest@chrome://mochikit/content/browser-test.js:1074:11
nextTest/<@chrome://mochikit/content/browser-test.js:904:14
SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23

"FullZoomChange for browser"

PASS Zoom reset button exists in Panel Menu -

console.log: Changing zoom for browser from 0.5 to 1
set fullZoom@chrome://global/content/elements/browser-custom-element.js:812:19
ZoomManager_setZoomForBrowser@chrome://global/content/viewZoomOverlay.js:60:7
FullZoom_reset/result<@chrome://browser/content/browser-fullZoom.js:425:21
promise callbackFullZoom_reset@chrome://browser/content/browser-fullZoom.js:423:42
oncommand@chrome://browser/content/browser.xhtml:1:10
@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_947914_button_zoomReset.js:34:19
AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1039:34
Tester_execTest@chrome://mochikit/content/browser-test.js:1074:11
nextTest/<@chrome://mochikit/content/browser-test.js:904:14
SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23

Which is pretty broken. This seems to me was mostly passing by chance, but with
my Fission changes which made FullZoomChange events more async (actually, not
notify twice) it started failing.

Wait to load a page before changing the zoom level so that the browser doesn't
reset it when navigating.

Comment 5

[Intermittent Failures Robot]

93 failures in 999 pushes (0.093 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 91
• mozilla-central: 2

Platform breakdown:

• windows10-64-qr: 2
• windows7-32-shippable: 1
• macosx1014-64: 41
• macosx1014-64-shippable: 47
• windows10-64-ccov: 1
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1612427&startday=2020-04-23&endday=2020-04-23&tree=all

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1da06953299
Fix flaky browser_947914_button_zoomReset.js. r=Gijs

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b1da06953299

Comment 8

[Intermittent Failures Robot]

52 failures in 1125 pushes (0.046 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 35
• mozilla-central: 10
• try: 7

Platform breakdown:

• macosx1014-64: 22
• macosx1014-64-shippable: 25
• windows10-64-qr: 1
• windows10-64-shippable: 2
• macosx1014-64-devedition: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1612427&startday=2020-04-24&endday=2020-04-24&tree=all

Comment 9

[Intermittent Failures Robot]

145 failures in 5582 pushes (0.026 failures/push) were associated with this bug in the last 7 days.

This is the #6 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 126
• mozilla-central: 12
• try: 7

Platform breakdown:

• windows10-64-qr: 3
• windows7-32-shippable: 1
• macosx1014-64: 63
• macosx1014-64-shippable: 72
• windows10-64-ccov: 1
• windows10-64: 1
• windows10-64-shippable: 2
• macosx1014-64-devedition: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1612427&startday=2020-04-20&endday=2020-04-26&tree=all