Closed
Bug 161243
Opened 23 years ago
Closed 23 years ago
[FIX]remove the NS_FORM_NOTSET and NS_FORM_NOTOK nsresult values
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla1.2alpha
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
29.56 KB,
patch
|
john
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
We can just punt these...
|
Assignee | |
Comment 1•23 years ago
|
||
|
|
Assignee | |
Updated•23 years ago
|
Keywords: review
Priority: -- → P2
Summary: remove the NS_FORM_NOTSET and NS_FORM_NOTOK nsresult values → [FIX]remove the NS_FORM_NOTSET and NS_FORM_NOTOK nsresult values
Target Milestone: --- → mozilla1.2alpha
|
||
Comment 2•23 years ago
|
||
Comment on attachment 94156 [details] [diff] [review]
I got carried away. The new code is cleaner...
sr=jst
Attachment #94156 -
Flags: superreview+
|
||
Comment 3•23 years ago
|
||
Comment on attachment 94156 [details] [diff] [review]
I got carried away. The new code is cleaner...
Sweet. r=jkeiser.
You probably should note in the GetNameAttr/GetType/etc. functions that it can
return NS_CONTENT_ATTR_NO_VALUE as well (when attr exists but has no value).
No need for new patch for that, if you do it.
Attachment #94156 -
Flags: review+
|
|
Assignee | |
Comment 4•23 years ago
|
||
fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•