1612477 - Remove `nsIDocumentStateListener::NotifyDocumentCreated()`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Meaningful implementation of nsIDocumentStateListener::NotifyDocumentCreated() is only ComposerCommandsUpdater. But it's already stored by HTMLEditor, thus, EditorBase::NotifyDocumentListeners() can notify ComposerCommandsUpdater of everything without nsIDocumentStateListener interface. Therefore, we can get rid of it.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1612477 - part 1: Make `ComposerCommandsUpdater` not inherit `nsIDocumentStateListener` r=m_kato!

This patch makes EditorBase::NotifyDocumentListeners() notify
ComposerCommandsUpdater via HTMLEditor::mComposerCommandsUpdater directly.
Therefore, ComposerCommandsUpdater can stop inheriting
nsIDocumentStateListener.

Note that this patch also makes ComposerCommandsUpdater::UpdateCommandGroup()
not take nsAString as its parameter because inlinning the
nsIDocumentStateListener requires ComposerCommandsUpdater.h to include
nsAString.h, but it's redundant and UpdateCommandGroup() just compares
it with literal strings. Therefore, using enum class for specifying command
group is faster.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1612477 - part 2: Remove `nsIDocumentStateListener.NotifyDocumentCreated()` r=m_kato!

There is no meaningful listener of this so that we can get rid of it.

Depends on D61357

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1612477 - part 3: Remove `nsIDocumentStateListener.NotifyDocumentCreated()` implementation from comm-central

Not tested yet.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/badf2dc13775
part 1: Make `ComposerCommandsUpdater` not inherit `nsIDocumentStateListener` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/78a3452181fa
part 2: Remove `nsIDocumentStateListener.NotifyDocumentCreated()` r=m_kato

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/badf2dc13775
https://hg.mozilla.org/mozilla-central/rev/78a3452181fa