Closed Bug 1612519 Opened 4 years ago Closed 4 years ago

Fix "Terminating worker revokes its URLs" WPT

Categories

(Core :: DOM: File, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

We need to register blobURLs in the worker's global even for DedicatedWorkers.

Assignee: nobody → amarchesini
Status: NEW → ASSIGNED

Yes. I wonder why we explicitly decided to not do that. Looking at the blame...

Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c6b4bb8a2736
Fix "Terminating worker revokes its URLs" WPT, r=smaug
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a422cac07967
Fix "Terminating worker revokes its URLs" WPT, r=smaug

Backed out changeset a422cac07967 (bug 1612519) for ESlint failure at browser/components/originattributes/test/browser/worker_blobify.js

Backout: https://hg.mozilla.org/integration/autoland/rev/ea1762ea3de859ee1e6257bf7d535b073d28e4d0

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=a422cac0796761fcef6e8da3edcf144f2c96c30c

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287203710&repo=autoland&lineNumber=310

[task 2020-02-02T08:37:54.169Z] 08:37:54.169 eslint (97) | Command: /usr/local/bin/node /builds/worker/checkouts/gecko/node_modules/eslint/bin/eslint.js --ext [js,jsm,jsx,xul,html,xhtml] --format json --no-error-on-unmatched-pattern --quiet --ignore-pattern devtools/shared/sprintfjs --ignore-pattern testing/mozbase/mozproxy/mozproxy/backends/mitm/scripts/catapult --ignore-pattern testing/xpcshell/node-ip --ignore-pattern devtools/shared/storage/vendor --ignore-pattern media/webrtc/signaling/src/sdp/sipcc --ignore-pattern devtools/client/shared/demangle.js --ignore-pattern mobile/android/geckoview/src/thirdparty --ignore-pattern media/libspeex_resampler --ignore-pattern media/libtremor --ignore-pattern devtools/client/debugger/flow-typed/npm --ignore-pattern media/libsoundtouch --ignore-pattern testing/web-platform/tests/tools/third_party --ignore-pattern media/openmax_dl --ignore-pattern testing/talos/talos/tests/kraken --ignore-pattern devtools/shared/heapsnapshot/CoreDump.pb.h --ignore-pattern media/mtransport/third_party --ignore-pattern testing/talos/talos/tests/v8_7 --ignore-pattern media/openmax_il --ignore-pattern testing/web-platform/tests/resources/webidl2 --ignore-pattern xpcom/build/mach_override.c --ignore-pattern testing/xpcshell/dns-packet --ignore-pattern media/kiss_fft --ignore-pattern media/ffvpx --ignore-pattern media/libnestegg --ignore-pattern media/webrtc/trunk --ignore-pattern media/libpng --ignore-pattern devtools/shared/acorn --ignore-pattern security/sandbox/chromium --ignore-pattern devtools/client/jsonview/lib/require.js --ignore-pattern mozglue/misc/decimal --ignore-pattern media/libmkv --ignore-pattern xpcom/io/crc32c.c --ignore-pattern testing/talos/talos/tests/dromaeo --ignore-pattern devtools/shared/qrcode/decoder --ignore-pattern media/libvorbis --ignore-pattern testing/mochitest/tests/MochiKit-1.4.2 --ignore-pattern security/nss --ignore-pattern devtools/client/shared/vendor --ignore-pattern ipc/chromium/src/third_party --ignore-pattern media/libyuv --ignore-pattern media/libopus --ignore-pattern media/libwebp --ignore-pattern devtools/shared/jsbeautify --ignore-pattern testing/modules/sinon-7.2.7.js --ignore-pattern testing/gtest/gtest --ignore-pattern security/sandbox/chromium-shim --ignore-pattern devtools/shared/qrcode/encoder --ignore-pattern testing/modules/ajv-4.1.1.js --ignore-pattern media/libdav1d --ignore-pattern testing/mochitest/MochiKit --ignore-pattern devtools/shared/node-properties --ignore-pattern media/libcubeb --ignore-pattern testing/xpcshell/node-http2 --ignore-pattern devtools/client/shared/build/babel.js --ignore-pattern devtools/client/shared/sourceeditor/test/cm_mode_ruby.js --ignore-pattern xpcom/build/mach_override.h --ignore-pattern testing/mochitest/pywebsocket --ignore-pattern parser/expat --ignore-pattern devtools/client/shared/source-map --ignore-pattern media/libjpeg --ignore-pattern devtools/shared/heapsnapshot/CoreDump.pb.cc --ignore-pattern media/libvpx --ignore-pattern media/libtheora --ignore-pattern testing/gtest/gmock --ignore-pattern devtools/client/shared/sourceeditor/codemirror --ignore-pattern media/libogg --ignore-pattern devtools/client/shared/sourceeditor/test/codemirror --ignore-pattern media/libaom /builds/worker/checkouts/gecko/media /builds/worker/checkouts/gecko/devtools /builds/worker/checkouts/gecko/mobile /builds/worker/checkouts/gecko/uriloader /builds/worker/checkouts/gecko/ipc /builds/worker/checkouts/gecko/xpfe /builds/worker/checkouts/gecko/security /builds/worker/checkouts/gecko/xpcom /builds/worker/checkouts/gecko/memory /builds/worker/checkouts/gecko/parser /builds/worker/checkouts/gecko/mozglue /builds/worker/checkouts/gecko/testing /builds/worker/checkouts/gecko/servo
[task 2020-02-02T08:38:52.768Z] 08:38:52.768 eslint (95) | Finished in 58.84 seconds
[task 2020-02-02T08:45:08.087Z] 08:45:08.85 eslint (98) | Finished in 434.15 seconds
[task 2020-02-02T08:46:06.370Z] 08:46:06.369 eslint (97) | Finished in 492.44 seconds
[task 2020-02-02T08:47:47.577Z] 08:47:47.577 eslint (96) | Finished in 593.64 seconds
[task 2020-02-02T08:47:47.584Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/components/originattributes/test/browser/worker_blobify.js:18:14 | 'e' is already declared in the upper scope. (no-shadow)
[task 2020-02-02T08:47:47.584Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/components/originattributes/test/browser/worker_blobify.js:29:9 | 'blobURL' is already defined. (no-redeclare)
[task 2020-02-02T08:47:47.584Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/components/originattributes/test/browser/worker_blobify.js:41:14 | 'e' is already declared in the upper scope. (no-shadow)
[taskcluster 2020-02-02 08:47:47.931Z] === Task Finished ===

Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f07131542aea
Fix "Terminating worker revokes its URLs" WPT, r=smaug
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: