Closed Bug 1612629 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 21535 - Connected k-rate AudioParams must get input values (1 of N)

Categories

(Core :: Web Audio, task, P4)

Product:
Core
Component:
Web Audio
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21535 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21535
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Connected k-rate AudioParams must get input values (1 of N)

When an AudioParam was selected to be k-rate, any inputs to the
AudioParam were ignored, so the AudioParam only contained the effect
of automation events. This is incorrect. Any inputs should be
reflected in the AudioParam values.

The case of connected AudioParams with a-rate automation was working fine.

Handles ConstantSource, Gain, and StereoPanner since these have very
similar AudioParam processing with only one simple AudioParam.

Bug: 1015760
Change-Id: I29ec3d7b58248a96da911e03890b74f6fb1bf098

Reviewed-on: https://chromium-review.googlesource.com/1873392
WPT-Export-Revision: d6edcf9dffb83387d3789cf61a81c834ecf85670

Component: web-platform-tests → Web Audio
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 47 tests

Status Summary

Firefox

OK : 2
PASS: 39[GitHub] 84[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 26

Chrome

OK : 2
PASS: 37
FAIL: 28

Safari

OK : 2
PASS: 11
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webaudio/the-audio-api/the-audioparam-interface/k-rate-connections.html
X pan[128:256]: Expected 0.5879377722740173 for all values but found 127 unexpected values:
Index Actual
[1] 0.588539719581604
[2] 0.5891402363777161
[3] 0.5897394418716431
[4] 0.5903372168540955
...and 123 more errors.: FAIL
X pan[512:640]: Expected 0.7071067690849304 for all values but found 127 unexpected values:
Index Actual
[1] 0.7071059346199036
[2] 0.707103431224823
[3] 0.7070993185043335
[4] 0.7070934772491455
...and 123 more errors.: FAIL
X pan[256:384]: Expected 0.6532814502716064 for all values but found 127 unexpected values:
Index Actual
[1] 0.653695821762085
[2] 0.6541085839271545
[3] 0.65451979637146
[4] 0.654929518699646
...and 123 more errors.: FAIL
X pan[896:1024]: Expected 0.5879377722740173 for all values but found 127 unexpected values:
Index Actual
[1] 0.5873345136642456
[2] 0.5867298245429993
[3] 0.5861237049102783
[4] 0.5855162739753723
...and 123 more errors.: FAIL
X pan[384:512]: Expected 0.6935199499130249 for all values but found 127 unexpected values:
Index Actual
[1] 0.6937307119369507
[2] 0.6939398646354675
[3] 0.6941474080085754
[4] 0.6943533420562744
...and 123 more errors.: FAIL
X pan[640:768]: Expected 0.6935199499130249 for all values but found 127 unexpected values:
Index Actual
[1] 0.6933075189590454
[2] 0.6930934190750122
[3] 0.6928777694702148
[4] 0.6926604509353638
...and 123 more errors.: FAIL
X pan[768:896]: Expected 0.6532814502716064 for all values but found 127 unexpected values:
Index Actual
[1] 0.6528656482696533
[2] 0.6524482369422913
[3] 0.652029275894165
[4] 0.6516088247299194
...and 123 more errors.: FAIL
X pan[0:128]: Expected 0.5 for all values but found 127 unexpected values:
Index Actual
[1] 0.500766396522522
[2] 0.5015316009521484
[3] 0.5022956728935242
[4] 0.5030585527420044
...and 123 more errors.: FAIL

AUDIT TASK RUNNER FINISHED: 1 out of 2 tasks were failed.: FAIL

< [StereoPanner] 8 out of 8 assertions were failed.: FAIL
/webaudio/the-audio-api/the-audioparam-interface/k-rate-constant-source.html
X k-rate offset k-rate output [256: 383]: Expected 5 for all values but found 127 unexpected values:
Index Actual
[1] 5.01953125
[2] 5.0390625
[3] 5.05859375
[4] 5.078125
...and 123 more errors.: FAIL
X k-rate ConstantSource.offset: output[640:768]: Expected 640 for all values but found 127 unexpected values:
Index Actual
[1] 641
[2] 642
[3] 643
[4] 644
...and 123 more errors.: FAIL
< [ConstantSourceNode.offset k-rate automation] 8 out of 8 assertions were failed.: FAIL
< [ConstantSource k-rate offset] 5 out of 12 assertions were failed.: FAIL
X k-rate ConstantSource.offset: output[896:1024]: Expected 896 for all values but found 127 unexpected values:
Index Actual
[1] 897
[2] 898
[3] 899
[4] 900
...and 123 more errors.: FAIL
X k-rate offset: Difference between a-rate and k-rate ConstantSourceNode should have contain at least one value different from 0.: FAIL
X k-rate offset k-rate output [128: 255]: Expected 2.5 for all values but found 127 unexpected values:
Index Actual
[1] 2.51953125
[2] 2.5390625
[3] 2.55859375
[4] 2.578125
...and 123 more errors.: FAIL
X k-rate ConstantSource.offset: output[0:128]: Expected 0 for all values but found 127 unexpected values:
Index Actual
[1] 1
[2] 2
[3] 3
[4] 4
...and 123 more errors.: FAIL
X k-rate ConstantSource.offset: output[128:256]: Expected 128 for all values but found 127 unexpected values:
Index Actual
[1] 129
[2] 130
[3] 131
[4] 132
...and 123 more errors.: FAIL
X k-rate ConstantSource.offset: output[512:640]: Expected 512 for all values but found 127 unexpected values:
Index Actual
[1] 513
[2] 514
[3] 515
[4] 516
...and 123 more errors.: FAIL
X k-rate ConstantSource.offset: output[256:384]: Expected 256 for all values but found 127 unexpected values:
Index Actual
[1] 257
[2] 258
[3] 259
[4] 260
...and 123 more errors.: FAIL
X k-rate offset k-rate output [384: 511]: Expected 7.5 for all values but found 127 unexpected values:
Index Actual
[1] 7.51953125
[2] 7.5390625
[3] 7.55859375
[4] 7.578125
...and 123 more errors.: FAIL
X k-rate offset k-rate output [0: 127]: Expected 0 for all values but found 127 unexpected values:
Index Actual
[1] 0.01953125
[2] 0.0390625
[3] 0.05859375
[4] 0.078125
...and 123 more errors.: FAIL

AUDIT TASK RUNNER FINISHED: 2 out of 3 tasks were failed.: FAIL

X k-rate ConstantSource.offset: output[768:896]: Expected 768 for all values but found 127 unexpected values:
Index Actual
[1] 769
[2] 770
[3] 771
[4] 772
...and 123 more errors.: FAIL
X k-rate ConstantSource.offset: output[384:512]: Expected 384 for all values but found 127 unexpected values:
Index Actual
[1] 385
[2] 386
[3] 387
[4] 388
...and 123 more errors.: FAIL

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3019d8332cf3 [wpt PR 21535] - Connected k-rate AudioParams must get input values (1 of N), a=testonly https://hg.mozilla.org/integration/autoland/rev/1a57f289e05b [wpt PR 21535] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3019d8332cf3
https://hg.mozilla.org/mozilla-central/rev/1a57f289e05b

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.