Closed Bug 1612639 Opened 4 years ago Closed 4 years ago

Intermittent TEST-UNEXPECTED-PASS | /web-animations/timing-model/animations/playing-an-animation.html | Playing a canceled animation backwards sets the start time - expected FAIL

Categories

(Core :: DOM: Animation, defect, P5)

Product:
Core
Component:
DOM: Animation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: birtles)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1612639 - Fix flaky upstreamed Web Animations WPT; r?hiro
47 bytes, text/x-phabricator-request
Details | Review

Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=287120845&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/fNI1sHP2TOSOisXOW_9Xrg/runs/0/artifacts/public/logs/live_backing.log

[task 2020-01-31T22:07:41.701Z] 22:07:41 INFO - TEST-PASS | /web-animations/timing-model/animations/playing-an-animation.html | Resuming an animation from paused calculates start time from hold time
[task 2020-01-31T22:07:41.701Z] 22:07:41 INFO - TEST-PASS | /web-animations/timing-model/animations/playing-an-animation.html | If a pause operation is interrupted, the ready promise is reused
[task 2020-01-31T22:07:41.701Z] 22:07:41 INFO - TEST-PASS | /web-animations/timing-model/animations/playing-an-animation.html | A pending playback rate is used when determining auto-rewind behavior
[task 2020-01-31T22:07:41.701Z] 22:07:41 INFO - TEST-FAIL | /web-animations/timing-model/animations/playing-an-animation.html | Playing a canceled animation sets the start time - assert_approx_equals: The start time of the playing animation should be set expected 296.34 +/- 0.001 but got 293.18
[task 2020-01-31T22:07:41.701Z] 22:07:41 INFO - window.assert_times_equal@http://web-platform.test:8000/web-animations/testcommon.js:24:25
[task 2020-01-31T22:07:41.701Z] 22:07:41 INFO - @http://web-platform.test:8000/web-animations/timing-model/animations/playing-an-animation.html:153:21
[task 2020-01-31T22:07:41.701Z] 22:07:41 INFO - asyncTest.prototype.step@http://web-platform.test:8000/resources/testharness.js:2024:25
[task 2020-01-31T22:07:41.701Z] 22:07:41 INFO - promise_test/tests.promise_tests</<@http://web-platform.test:8000/resources/testharness.js:605:36
[task 2020-01-31T22:07:41.702Z] 22:07:41 INFO - promise_test/tests.promise_tests<@http://web-platform.test:8000/resources/testharness.js:604:20
[task 2020-01-31T22:07:41.702Z] 22:07:41 INFO - promise callbackpromise_test@http://web-platform.test:8000/resources/testharness.js:603:51
[task 2020-01-31T22:07:41.702Z] 22:07:41 INFO - @http://web-platform.test:8000/web-animations/timing-model/animations/playing-an-animation.html:141:13
[task 2020-01-31T22:07:41.702Z] 22:07:41 INFO - TEST-UNEXPECTED-PASS | /web-animations/timing-model/animations/playing-an-animation.html | Playing a canceled animation backwards sets the start time - expected FAIL
[task 2020-01-31T22:07:41.702Z] 22:07:41 INFO - TEST-INFO | expected FAIL
[task 2020-01-31T22:07:41.702Z] 22:07:41 INFO - TEST-OK | /web-animations/timing-model/animations/playing-an-animation.html | took 1330ms

Brian does the expectancy here need to be updated or wait until the failure rate is higher?

Flags: needinfo?(brian)

(In reply to Andreea Pavel [:apavel] from comment #2)

Brian does the expectancy here need to be updated or wait until the failure rate is higher?

That test is just a buggy test (it comes from the Chrome WPT sync). It really shouldn't have been landed in WPT. We should just fix it along with any other flaky tests from that PR: https://github.com/web-platform-tests/wpt/pull/21463

I'll look at it tomorrow.

Assignee: nobody → brian
Status: NEW → ASSIGNED
Flags: needinfo?(brian)

These tests assume that the startTime of the animation is set to the current
frame time but nothing in the spec requires that.

Pushed by bbirtles.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85d7cda3695a
Fix flaky upstreamed Web Animations WPT; r=hiro
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21648 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

https://hg.mozilla.org/mozilla-central/rev/85d7cda3695a

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Upstream PR merged by moz-wptsync-bot

I have filed bug 1614032 for the timeout mentioned in Comment 9.

See Also: → 1614032

(In reply to Dorel Luca [:dluca] from comment #9)

It looks like this is still happening on central:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=287937050

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=287937050&repo=mozilla-central&lineNumber=826

Brian, can you please take a look this ?

Looks like this was a once-off timeout that is now tracked by bug 1614032.

Flags: needinfo?(brian)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: