1612789 - Dragging imported folders in bookmark manager does not move all nested bookmarks

Status: UNCONFIRMED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Bob Kline]

Attachment: Screen shot from chrome showing nested bookmarks

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

Exit Chrome browser
Open Firefox browser
Open Library > Bookmarks > Show All Bookmarks
Select Import and backup your bookmarks > Import Data from Another Browser ...
Select Chrome
Click Continue
Check all items for importing
Click Continue
Provide authorization for access to Chrome data
Click Done at the Import Complete dialog box
Drag top-level folders from "From Google Chrome" to "Bookmarks Toolbar"

Actual results:

Nested folders on the bookmarks toolbar are empty.

Expected results:

The nested bookmarks should appear on the bookmarks toolbar.

Comment 1

[Bob Kline]

Attachment: Screen shot showing nested bookmarks in Firefox

Comment 2

[Bob Kline]

Attachment: Screen shot showing missing bookmarks after dragging parent folder to Bookmarks Toolbar

Comment 3

[Bob Kline]

I changed the title because I was unable to reproduce the behavior with folders created directly in Firefox.

Comment 4

[Matthew N. [:MattN]]

The relevant code is at https://searchfox.org/mozilla-central/rev/3811b11b5773c1dccfe8228bfc7143b10a9a2a99/browser/components/migration/ChromeProfileMigrator.jsm#254-262 so it's possible there is a bug with MigrationUtils.createImportedBookmarksFolder or MigrationUtils.insertManyBookmarksWrapper but those are just wrappers around PlacesUtils.bookmarks.insert and PlacesUtils.bookmarks.insertTree. It would be great if this could be fixed as part of Places work as I don't see it getting prioritized as migration work any time soon.

Comment 5

[Marco Bonardo [:mak]]

Hm, the import process is async, I wonder if this is just a result of not waiting long enough for it to be complete.
Anyway, I have a couple questions to better understand what's up:

(In reply to Bob Kline from comment #0)

Drag top-level folders from "From Google Chrome" to "Bookmarks Toolbar"

Ok, so at this point, from what I understood, you see the imported bookmarks in the Library under the From Google Chrome folder (screenshot in comment 1), but when you drag one of this folders elsewhere (the toolbar in this case), you get an empty folder and the contained bookmarks disappear (screenshot in comment 2).
Is this correct? If so bookmarks are properly imported, but then something goes wrong when moving them.
Do bookmarks reappear if you close and reopen Firefox? Were those bookmarks moved elsewhere (like in unfiled bookmarks) by chance?
Do you have Sync enabled in Firefox?

We should try to reproduce this failure.

Comment 6

[Bob Kline]

Ok, so at this point, from what I understood, you see the imported bookmarks in the Library under the From Google Chrome folder (screenshot in comment 1), but when you drag one of this folders elsewhere (the toolbar in this case), you get an empty folder and the contained bookmarks disappear (screenshot in comment 2).

More precisely: when I drag type top-level imported folders to the toolbar, those folders are not themselves empty, but the nested folders inside them have lost their bookmarks.

Do bookmarks reappear if you close and reopen Firefox?

No.

Were those bookmarks moved elsewhere (like in unfiled bookmarks) by chance?

I'm afraid I don't know, as I cleaned up the bookmarks aggressively, to leave only the bookmarks on the toolbar. I'm reluctant to do further experimenting on my working installation, lest I mess up what I've finally (after a lot of manual work) gotten the bookmarks to match what I had in Chrome.

Do you have Sync enabled in Firefox?

Yes.

Comment 7

[Marco Bonardo [:mak]]

we should try to reproduce this and see what's up.