1612802 - Reject IME notifications from content processes other than the currently focused one

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

Description

[Henri Sivonen (:hsivonen)]

In reference to bug 1556627 comment 182, we should look into rejecting IME notifications from content processes that aren't the focused one in case blurring the previously-focused content process is handled slowly in the previously-focused content process process and it sends IME notifications meanwhile.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, we've already been doing this in BrowserParent, for example:
https://searchfox.org/mozilla-central/rev/919607a3610222099fbfb0113c98b77888ebcbfb/dom/ipc/BrowserParent.cpp#2157

However, looks like that a remote process still sends a blur message to the main process when destroying the active IMEContentObserver from IMEStateManager::StopIMEStateManagement(). We should stop doing it.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1612802 - Make `IMEStateManager` stop notifying `PuppetWidget` of editor state changes while its `StopIMEStateManagement()` r=m_kato!

Currently, BrowserParent rejects any notifications which come after
it blurs from IME focus.
https://searchfox.org/mozilla-central/rev/919607a3610222099fbfb0113c98b77888ebcbfb/dom/ipc/BrowserParent.cpp#2157,2169,2181,2192,2203,2216

But for saving unnecessary IPC messages, we should make IMEStateManager in
a content process stop sending notifications which occurs during its
StopIMEStateManagement() is called.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe681c163180
Make `IMEStateManager` stop notifying `PuppetWidget` of editor state changes while its `StopIMEStateManagement()` r=m_kato

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fe681c163180