1612823 - Watch Expressions "refresh" button is never displayed

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Julian Descottes [:jdescottes]]

Initially reported on Discourse by @lanesun : https://discourse.mozilla.org/t/add-a-refresh-button-to-the-watcher/53124

What were you doing?

1. Open DevTools, select Debugger
2. Add a watch expression

What happened?

The watch expression header is supposed to display a "refresh" button, but it's ot visible

What should have happened?

Refresh button should be visible.

Anything else we should know?

The issue comes from the following check:
https://searchfox.org/mozilla-central/rev/2e355fa82aaa87e8424a9927c8136be184eeb6c7/devtools/client/debugger/src/components/SecondaryPanes/index.js#186

  watchExpressionHeaderButtons() {
    const { expressions } = this.props;

    const buttons = [];

    if (expressions.size) {
      // ...
    }
  }

Looking at the props, expressions is supposed to be an Immutable List (which should therefore expose a "size" property). However at runtime, the expressions prop is an Array.

Comment 1

[Julian Descottes [:jdescottes]]

Nicolas, thanks for proposing to bisect the regression! Don't hesitate to send it back to me if you don't have time to hunt it down.

Comment 2

[Julian Descottes [:jdescottes]]

(ok I had a feeling it was Bug 1558303, and indeed https://hg.mozilla.org/mozilla-central/rev/74f226b5b684 is the regressing change. clearing ni?)

Comment 3

[Julian Descottes [:jdescottes]]

Let's fix this and add a test.

I noticed that the refresh only works well with simple types. If I am watching an object, refresh will not show additional/updated properties.
Maybe an issue with the object inspector?

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1612823 - Display refresh button in Debugger watch expressions panel

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1612823 - Remove remaining mentions of Immutable in Debugger codebase

Depends on D61451

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0594c4fc1b67
Display refresh button in Debugger watch expressions panel r=jlast
https://hg.mozilla.org/integration/autoland/rev/494913315ee3
Remove remaining mentions of Immutable in Debugger codebase r=jlast

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0594c4fc1b67
https://hg.mozilla.org/mozilla-central/rev/494913315ee3