1612848 - Crash in [@ mozilla::dom::Window_Binding::matchMedia]

Status: RESOLVED WORKSFORME

(Core :: DOM: Bindings (WebIDL), defect, P5)

Description

[Pascal Chevrel:pascalc (PTO until Sept 2)]

This bug is for crash report bp-942651c6-22b1-4b21-839c-a80660200126.

Top 10 frames of crashing thread:

0 xul.dll mozilla::dom::Window_Binding::matchMedia dom/bindings/WindowBinding.cpp:3843
1 xul.dll mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::MaybeCrossOriginObjectThisPolicy, mozilla::dom::binding_detail::ThrowExceptions> dom/bindings/BindingUtils.cpp:3151
2 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:542
3 xul.dll Interpret js/src/vm/Interpreter.cpp:3018
4 xul.dll js::RunScript js/src/vm/Interpreter.cpp:422
5 xul.dll js::ExecuteKernel js/src/vm/Interpreter.cpp:798
6 xul.dll ExecuteInExtensibleLexicalEnvironment js/src/builtin/Eval.cpp:493
7 xul.dll js::ExecuteInJSMEnvironment js/src/builtin/Eval.cpp:600
8 xul.dll js::ExecuteInJSMEnvironment js/src/builtin/Eval.cpp:555
9 xul.dll mozJSComponentLoader::ObjectForLocation js/xpconnect/loader/mozJSComponentLoader.cpp:936

6 crashes in 74 Nightly with 20200125213807

Comment 1

[Andrew McCreight [:mccr8]]

matchmedia is some kind of CSS thing. Either the problem is there or in DOM bindings.

If you search for this signature, it only turns up one crash. I don't know why there is a discrepancy with the Crash Data information in this bug.

The crash in comment 0 is happening from a call in a JSM, which might be interesting.

Comment 2

[Boris Zbarsky [:bzbarsky]]

The crash in comment 0 is claiming that the crash happened on the entry-point to Window_Binding::matchMedia, right? That seems unlikely.

The one crash I see in crash-stats is https://crash-stats.mozilla.org/report/index/58de24b9-7131-493c-b794-e8adf0200129, which is claimed to be an "EXCEPTION_ILLEGAL_INSTRUCTION" (as compared to the "EXCEPTION_ACCESS_VIOLATION_READ" in comment 0), and is fingering the AUTO_PROFILER_LABEL_DYNAMIC_FAST line.

Both crashes seem to be under the nsAppStartupNotifier::NotifyObservers(APPSTARTUP_CATEGORY) call in XREMain::XRE_mainRun().

Is it possible that we're early enough in startup that profiler stuff is not sufficiently initialized yet? Seems unlikely, since there's a AUTO_BASE_PROFILER_LABEL at the top of XREMain::XRE_main...

I don't think this has to do with CSS; if those line numbers are right, we're crashing in bindings code before any CSS stuff gets involved.

Comment 3

[Gabriele Svelto [:gsvelto]]

The crashes in nightly seem to come from a single installation so it might be just someone with flaky hardware.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.