Closed Bug 1613046 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21567 - [webnfc] Remove the limitation on the size of NDEF message

Categories

(Core :: DOM: Device Interfaces, task, P4)

Product:
Core
Component:
DOM: Device Interfaces
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla75
Tracking Flags:
Tracking Status
firefox75 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21567 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21567
Details from upstream follow.

Leon Han <leon.han@intel.com> wrote:

[webnfc] Remove the limitation on the size of NDEF message

Per the discussion at
https://github.com/w3c/web-nfc/issues/523#issuecomment-581785547,
such size limitation does not make much sense and does not bring much
benifit to WebDevs.

The spec issue:
https://github.com/w3c/web-nfc/issues/523

BUG=520391

Change-Id: Id5fcc8c349ac220c460646f055b78b812da8aeba

Reviewed-on: https://chromium-review.googlesource.com/2037310
WPT-Export-Revision: 4f79b863517e79dd50c8b308db14bcb53270b58c

Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 29 subtests

Status Summary

Firefox

OK : 1
FAIL: 29

Chrome

OK : 1
PASS: 6
FAIL: 23

Safari

OK : 1
FAIL: 29

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/web-nfc/NDEFWriter_write.https.html
NDEFWriter.write with 'empty' record should succeed.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write NDEFMessage containing embedded records.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should fail if user permission is not granted.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.write should fail with NetworkError when NFC data transfer fails.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that promise is rejected with TypeError if NDEFMessageSource is invalid.: FAIL (Chrome: PASS, Safari: FAIL)
Check that provided NDEFWriteOptions values are correctly converted.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should succeed to write data to an unformatted NFC device when the NDEFWriteOptions.overwrite is false.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should ignore reading data when ignoreRead is true.: FAIL (Chrome: FAIL, Safari: FAIL)
Synchronously signaled abort.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should fail if no implementation for NFC Mojo interface is available.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that mediaType should be set to 'application/octet-stream' if NDEFRecordInit.record's recordType is 'mime' and NDEFRecordInit.record's mediaType is undefined.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFWriter.write succeeds when message is ArrayBufferView.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFWriter.write succeeds when message is ArrayBuffer.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that promise is rejected with SyntaxError if NDEFMessageSource contains invalid records.: FAIL (Chrome: PASS, Safari: FAIL)
Test that WebNFC API is not accessible from iframe context.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.write should fail if abort write request before write happends.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should fail when the NFC device coming up does not expose NDEF technology.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should fail if signal is not an AbortSignal.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFWriter.write should succeed to overwrite the existing data when the NDEFWriteOptions.overwrite is true.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that NDEFWriter.write succeeds when message is DOMString.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should read data when ignoreRead is false.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write NDEFMessage containing text, mime, unknown, url, absolute-url and external records with default NDEFWriteOptions.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should fail when NFC HW is disabled.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should fail when there are NDEF records on the NFC device and NDEFWriteOptions.overwrite is false.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should fail if signal's aborted flag is set.: FAIL (Chrome: PASS, Safari: FAIL)
Check that default NDEFWriteOptions values are correctly set.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should replace all previously configured write operations.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should fail when NFC HW is not supported.: FAIL (Chrome: FAIL, Safari: FAIL)
NDEFWriter.write should succeed when NFC HW is enabled: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/246094499ecd
[wpt PR 21567] - [webnfc] Remove the limitation on the size of NDEF message, a=testonly

https://hg.mozilla.org/mozilla-central/rev/246094499ecd

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox75: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.