1613059 - Generate (Password) new-password does not work after Master Password is dismissed

Status: NEW

(Toolkit :: Password Manager, defect, P2)

Description

[Rares Doghi, Desktop QA]

Attachment: loginconsoleerror.txt

[Affected versions]:
Nightly 74.0a1

[Affected platforms]:
Platforms: ALL

[Steps to reproduce]:

1. Launch the Firefox browser and set a Master Password in about:preferences#privacy
2. Reach Facebook.com, save a login and restart the browser.
3. Reach Facebook.com after Restart and click Cancel at the Master Password prompt.
4. Open https://imgur.com/register in a new tab.
5. Using the Dev.Tools (F12) inspect the password field, edit it adding or changing autocomplete ="new-password" and focus away
6. Click on the password field.

Expected Result:
After Clicking the Password field the autocomplete dropdown contains "Use a securely generated password".

Actual Results:
The autocomplete dropdown is not displayed.
Note: Please note that if the user does not dismiss the Facebook Master Password prompt before editing the Password field this issue does not occur.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Note: Please note that if the user does not dismiss the Facebook Master Password prompt before editing the Password field this issue does not occur.

There is no "Facebook Master Password prompt", there is a single master password for the whole login store. We don't want to spam the user with prompts they have already cancelled. However, in this case where the current origin has changed we should probably re-prompt.

Giving this P2 as we are currently trying to bring password generation to feature complete-ness.

Comment 2

[Timea Cernea [:tbabos][inactive]]

This is more simply reproduced with the Context Menu option for the Password Fields.
STR:

1. Start Firefox with Master password set up
2. Dismiss or cancel the auth dialog for master password
3. Go to any site
4. Right-click on password field - > Use Generated Password

Result: Autocomplete dropdown is displayed but shows only the 'View Saved Logins" footer.

Hey Sam, given that "Fill login" and "Fill Passwords" context menu options are also grayed out in this scenario, is password generation even supposed to be allowed without auth with master password? I was wondering if it wouldn't be better to gray it out too since it doesn't offer any functionality like this...

Comment 3

[Timea Cernea [:tbabos][inactive]]

Actually, what I described is a different issue, this is about prompting the master password again upon navigating to a different site. Canceling the NI? for Sam

Comment 4

[pwosj]

definitely confusing behaviour as to why the autofill wouldn't work on a new site.