Closed Bug 1613074 Opened 4 years ago Closed 4 years ago

Enable -Wunused-function & -Wunused-variable at the build phase

Categories

(Firefox Build System :: General, task)

task
Not set
normal

Tracking

(firefox74 fixed)

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We fixed a bunch of the issues. I think it is ready to be enabled by default.

Product: Core → Firefox Build System
No longer blocks: buildwarning
Blocks: buildwarning
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b59b628a7af6
Enable -Wunused-function & -Wunused-variable at the build phase r=froydnj
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

Why do we need to manually enable -Wunused-function and -Wunused-variable? Aren't they implicitly enabled by -Wunused, which is implicitly enabled by -Wall?

https://github.com/Barro/compiler-warnings/blob/master/clang/warnings-clang-top-level-8.txt#L200-L201

See Also: → 1718408
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: