1613134 - Importing different (password/same user + origin) credentials from edge chromium doesn't create new entries in Firefox

Status: RESOLVED INVALID

(Firefox :: Migration, defect)

Description

[Negritas Sergiu, Desktop QA]

Attachment: pre-import ss.PNG

Prerequisites

• Have some credentials saved in Microsoft Edge Chromium and the same credentials (username and origin) but with different password saved in Firefox.

Affected versions

• 74.0a1 (2020-02-03)(https://hg.mozilla.org/mozilla-central/rev/9f8766e42efea809351839114d64085d7518adf9)

Affected platforms

• Windows 10

Steps to reproduce

1. Open Firefox.
2. Navigate to the about:logins page.
3. In the about:logins page click on the ... button and in the sub-menu click on the Import Passwords... option.
4. Follow the Import Wizard instructions and import from Microsoft Edge Chromium.

Expected result

• Firefox should import all the logins and create duplicates for entries that have the same username and origin but different password.

Actual Result

• Firefox creates new entries for logins that aren't stored already but it doesn't create duplicates for the login entries that have the same username and origin but different password.

Regression range

• Potentially regressed by: https://bugzilla.mozilla.org/show_bug.cgi?id=1608513

Additional notes

• Please see the attached screenshots.

Comment 1

[Negritas Sergiu, Desktop QA]

Attachment: post-import ss.PNG

Comment 2

[Matthew N. [:MattN]]

(In reply to Negritas Sergiu from comment #0)

Expected result

• Firefox should import all the logins and create duplicates for entries that have the same username and origin but different password.

Why would a user want duplicates? We are trying to reduce duplicates in general. IIRC we use the timestamp to determine which password is newer. Can you confirm that?

Comment 3

[Negritas Sergiu, Desktop QA]

Hello! I was looking into the questions you asked and indeed Firefox Import manager uses timestamp to determine which password is newer. I can confirm that the time stamp used is the created one and Firefox only overwrites existing entries if the imported password is newer than the one stored already. Also shouldn't we use when importing the same credentials the last used timestamp?

Comment 4

[Matthew N. [:MattN]]

(In reply to Negritas Sergiu from comment #3)

Also shouldn't we use when importing the same credentials the last used timestamp?

No, because the last used timestamp can also be updated when a log in fails.