1613160 - PiP toggle conflicts with youtube miniplayer due to "next" button

Status: RESOLVED INVALID

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Simona Badau, Desktop QA]

Attachment: pipIssue.mp4

Mozilla/5.0 (X11; Linux i686; rv:74.0) Gecko/20100101 Firefox/74.0
Build ID: 20200204095729

Affected versions:

• Nightly 74.0a1
• latest Firefox 73 beta
• Firefox 72.0.2

Affected platforms:

• Windows 10
• Mac OS X 10.15
• Ubuntu 18.04

Steps to reproduce:

1. Launch Firefox and navigate to YouTube
2. Click on any video and enable the "Miniplayer" mode
3. Hover your mouse over the PiP button.

Actual results:
The PiP button expands behind the "Next" video button and both buttons can be clicked at the same time.

Expected results:
The Pip button should not expand over the Next button.
For more details, please see the video:
https://imgur.com/a/RgVkGW4

Comment 1

[:Gijs (he/him)]

It's not clear to me what we can do about this from the Firefox side. We have no control over the web page markup, and the size of the video (which is what we discriminated on in bug 1547795) is big enough that that's not useful here.

Adam, do you have ideas?

Comment 2

[Adam Stevenson [:adamopenweb]]

Thanks for reporting. We are able to move the PiP button to a few positions on the page using the Webcompat add-on. But I think it will move for all of the videos on Youtube, which is not terrible I suppose.

I will bring this up with Mike and UX to see if we have other ideas, before going this route. Leaving my NI.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Currently, yes, moving the toggle via the webcompat addon will move the toggle for all videos in a particular domain. We cannot currently target specific types of elements (which would likely be pretty brittle).

What strikes me as perhaps more problematic here is that the PiP toggle is accepting the click event even though the mouse is clearly over something opaque. When the toggle is occluded, we should definitely be falling back to letting the page handle the click.

Comment 4

[kpatenio]

This seems to be relevant to the older pip toggle, rather than the current one (the toggle no longer overlaps over the next button in miniplayer mode). I think we can close this bug. Thoughts on this, Mike?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Yep, I concur. Thanks!