Revisions to bytecode documentation in Opcodes.h
Categories
(Core :: JavaScript Engine, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(2 files)
I'm working on the new emitter and found some stuff that could be better.
|
Assignee | |
Comment 1•4 years ago
|
||
The word "must" is used to mark rules that valid bytecode must follow or risk
MOZ_CRASH, assertion failures, or undefined behavior. Documenting all of them
is an aspirational goal; this revision notes a bunch that were accidentally
skipped before, and adds the word "must" in some places.
The rule that hops and slot must be reasonable is documented at the top of
the file, under "Other operands", and does not need to be repeated in the
documentation for any instruction.
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D62519
|
||
Comment 3•4 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jorendorff, could you have a look please?
For more information, please visit auto_nag documentation.
Pushed by jorendorff@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a237cfee865a Part 1: General revisions of comments in vm/Opcodes.h. r=tcampbell. https://hg.mozilla.org/integration/autoland/rev/133106a4770f Part 2: Document generator/async instructions in vm/Opcodes.h. r=tcampbell.
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a237cfee865a
https://hg.mozilla.org/mozilla-central/rev/133106a4770f
|
|
Assignee | |
Updated•4 years ago
|
Description
•