1613252 - Marking.cpp: redundant return statement at the end of a function with a void return type

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/js/src/gc/Marking.cpp#1579

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[siddharth_yadav]

Hi. I would like to work on this. Please assign this issue to me.

Comment 2

[Mahak]

Hey !!
Can I work on this issue?

Comment 3

[Andi [:andi]]

If you want to work on this issue assign it to yourself and post a patch.

Thanks!

Comment 4

[Mahak]

Attachment: Bug 1613252 - Removes redundant return statement at the end of a function with void return type in Marking.cpp

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c5a23917a36
Removes redundant return statement at the end of a function with void return type in Marking.cpp r=sylvestre

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3c5a23917a36