Closed Bug 1613252 Opened 2 years ago Closed 2 years ago

Marking.cpp: redundant return statement at the end of a function with a void return type

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set
normal

Tracking

(firefox75 fixed)

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: Sylvestre, Assigned: mbansal, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/js/src/gc/Marking.cpp#1579

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Hi. I would like to work on this. Please assign this issue to me.

Hey !!
Can I work on this issue?

If you want to work on this issue assign it to yourself and post a patch.

Thanks!

Assignee: nobody → mbansal
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c5a23917a36
Removes redundant return statement at the end of a function with void return type in Marking.cpp r=sylvestre
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.