1613255 - nsNSSCertificate.cpp: redundant return statement at the end of a function with a void return type

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

Filling as a good first bug to learn workflows.

return; at the end of a void function is useless
https://searchfox.org/mozilla-central/source/security/manager/ssl/nsNSSCertificate.cpp#577

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Comment 1

[Adnan Rahman Chowdhury]

Please assign it to me. I'd like to start contributing to Firefox with this bug.

Comment 2

[Adnan Rahman Chowdhury]

Whom should I assign for review?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Sorry, I missed your message.
See https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html#to-write-a-patch to find a reviewer

Comment 4

[Adnan Rahman Chowdhury]

OK. I've committed my change with a reviewer mentioned in the commit message. I haven't used Phabricator. Do I need to do that?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Not sure what you mean but yeah, you have to use phabricator

Comment 6

[Adnan Rahman Chowdhury]

Please assign this bug to someone else. I'm not having enough time. :(

Comment 7

[manas]

This seems like a great opportunity to learn! Please assign this bug to me so I can contribute!

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Please provide a patch and it will be automatically assigned to you.
If someone takes it before you, I will create a new good first bug for you!

Comment 9

[manas]

Attachment: Bug 1613255 - Remove redundant return statement. r?Sylvestre

Comment 10

[manas]

I pushed a patch. Did I do it right?

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Yeah, bravo.
I just have a minor request!
Thanks

Comment 12

[manas]

Attachment: Bug 1613255 - Remove redundant return and spaces. r?Sylvestre

Depends on D64354

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3aecdee319b
Remove redundant return statement. r=sylvestre

Comment 14

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d3aecdee319b