1613292 - Web share impl is using a localized string for a web-visible exception

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is both a privacy leak and a compat risk.

Navigator::Share has this bit:

    nsAutoString message;
    nsContentUtils::GetLocalizedString(nsContentUtils::eDOM_PROPERTIES,
                                       "WebShareAPI_NeedOneMember", message);
    aRv.ThrowTypeError<MSG_MISSING_REQUIRED_DICTIONARY_MEMBER>(message);
    return nullptr;

There are two problems here:

1. We should not be throwing localized strings to content as exceptions.
2. This is misusing the MSG_MISSING_REQUIRED_DICTIONARY_MEMBER error, which expects a single argument: a description of the member. The string here is adding all sorts of other stuff, and will break badly if the MSG_MISSING_REQUIRED_DICTIONARY_MEMBER message is reworded.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1613292. Stop throwing localized errors from web share code to web content.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/497d7a741b54
Stop throwing localized errors from web share code to web content. r=farre

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/497d7a741b54