1613363 - Maybe<T> should preserve trivial copy-constructability and destructability of T

Status: RESOLVED FIXED

(Core :: MFBT, task)

Description

[Simon Giesecke [:sg] [he/him]]

See also https://bugzilla.mozilla.org/show_bug.cgi?id=1572205#c7.

Comment 1

[Simon Giesecke [:sg] [he/him]]

This should include preserving trivial-copyability as well. Currently, e.g. passing a Maybe<int64_t> triggers a clang-tidy warning, which is not meaningful:

Warning: The const qualified parameter 'aNewVersion' is copied for each invocation; consider making it a reference [clang-tidy: performance-unnecessary-value-param]

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1613363 - Maybe<T> should preserve trivial copy-constructability and destructability of T. r=froydnj

Depends on D68172

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec923b3c5f45
Maybe<T> should preserve trivial copy-constructability and destructability of T. r=froydnj

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ec923b3c5f45