Closed Bug 1613366 Opened 4 years ago Closed 4 years ago

Progress and printing labels are backwards

Categories

(Toolkit :: Printing, defect, P1)

Product:
Toolkit
Component:
Printing
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox-esr68 --- wontfix
firefox72 --- wontfix
firefox73 --- wontfix
firefox74 --- fixed

People

(Reporter: flod, Assigned: Gijs)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1613366 - revert print preview progress dialog word order, r?flod
47 bytes, text/x-phabricator-request
Details | Review

Before the migration to Fluent it was

Progress: Preparing…

<row class="thin-separator">
    <hbox pack="end">
        <label id="dialog.progressSpaces" value="&progress;"/>
    </hbox>
    <label id="dialog.progressLabel" value="&preparing;"/>
</row>

Now it's backward.

    <label id="dialog.progressSpaces" data-l10n-id="print-preparing" style="justify-self: end;"/>
    <label id="dialog.progressLabel" data-l10n-id="print-progress"/>

https://hg.mozilla.org/mozilla-central/rev/e0ce08d36f01e433c6fdc6293ca975ac44a1753c#l6.49

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
No longer blocks: 1523737
Keywords: regression
Priority: -- → P1
Regressed by: 1523737
Has Regression Range: --- → yes
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1f59ad1b9d22
revert print preview progress dialog word order, r=flod

https://hg.mozilla.org/mozilla-central/rev/1f59ad1b9d22

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: