1613375 - Reference frame origin offset should always be used for snapping, even if animated

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Andrew Osmond [:aosmond] (he/him)]

We currently only return an identity transform when a reference frame contains an animated transform:

https://searchfox.org/mozilla-central/rev/2e355fa82aaa87e8424a9927c8136be184eeb6c7/gfx/wr/webrender/src/spatial_node.rs#703

We should always incorporate the origin offset since that is fixed without a scene rebuild.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1613375 - Always use reference frame origin offset in snapping transforms.

We incorporate the reference frame origin offset for non-animated
transforms, but forgot for animated transforms. Since the offset itself
is not animated, we should still incorporate it into the snapping
transform.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2ed78dab7bc
Always use reference frame origin offset in snapping transforms. r=nical

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/a2ed78dab7bc